You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by necosta <gi...@git.apache.org> on 2018/03/13 16:08:48 UTC
[GitHub] zeppelin pull request #2863: Hotfix: ambiguous reference to overloaded defin...
GitHub user necosta opened a pull request:
https://github.com/apache/zeppelin/pull/2863
Hotfix: ambiguous reference to overloaded definition
### What is this PR for?
Minor bugfix on Zeppelin build from sources
### What type of PR is it?
Bug Fix
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3324
### How should this be tested?
* mvn clean package \
--batch-mode package \
-Phelium-dev \
-Pscala-2.11 \
-Dscala.version=2.11.8 \
-Dscala.binary.version=2.11 \
-Pbuild-distr \
-Pspark-2.1 \
-Dspark.version=2.1.1 \
-Pr \
-Pcassandra-spark-1.5 \
-Psparkr \
-Ppyspark \
-Phadoop-2.7 \
-Dhadoop.version=2.7.3 \
-Dmaven.findbugs.enable=false \
-Drat.skip=true \
-Dcheckstyle.skip=true \
-DskipTests
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin ZEPPELIN-3324
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2863.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2863
----
commit dfac740e1dac1b4d144ce41676597a34d4763264
Author: Nelson Costa <ne...@...>
Date: 2018-03-07T14:58:26Z
Hotfix: ambiguous reference to overloaded definition
----
---
[GitHub] zeppelin pull request #2863: Hotfix: ambiguous reference to overloaded defin...
Posted by necosta <gi...@git.apache.org>.
GitHub user necosta reopened a pull request:
https://github.com/apache/zeppelin/pull/2863
Hotfix: ambiguous reference to overloaded definition
### What is this PR for?
Minor bugfix on Zeppelin build from sources
### What type of PR is it?
Bug Fix
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3324
### How should this be tested?
* mvn clean package \
--batch-mode package \
-Phelium-dev \
-Pscala-2.11 \
-Dscala.version=2.11.8 \
-Dscala.binary.version=2.11 \
-Pbuild-distr \
-Pspark-2.1 \
-Dspark.version=2.1.1 \
-Pr \
-Pcassandra-spark-1.5 \
-Psparkr \
-Ppyspark \
-Phadoop-2.7 \
-Dhadoop.version=2.7.3 \
-Dmaven.findbugs.enable=false \
-Drat.skip=true \
-Dcheckstyle.skip=true \
-DskipTests
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin ZEPPELIN-3324
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2863.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2863
----
commit dfac740e1dac1b4d144ce41676597a34d4763264
Author: Nelson Costa <ne...@...>
Date: 2018-03-07T14:58:26Z
Hotfix: ambiguous reference to overloaded definition
----
---
[GitHub] zeppelin issue #2863: Hotfix: ambiguous reference to overloaded definition
Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2863
Hi @Leemoonsoo , @zjffdu , @andreaTP
I re-tested the bug is active (building against latest master - 881846364b08ec),
`
mvn clean package --batch-mode package -Phelium-dev -Pscala-2.11 -Dscala.version=2.11.8 -Dscala.binary.version=2.11 -Pbuild-distr -Pspark-2.1 -Dspark.version=2.1.1 -Pr -Pcassandra-spark-1.5 -Psparkr -Ppyspark -Phadoop-2.7 -Dhadoop.version=2.7.3 -Dmaven.findbugs.enable=false -Drat.skip=true -Dcheckstyle.skip=true -DskipTests
`
rebased this hotfix on top of latest master, and validated it works.
Struggling a bit in getting a green CI although giving it one final go on https://travis-ci.org/nokia/zeppelin/builds/362537813
Any final comments? Can we get this merged? Thanks.
---
[GitHub] zeppelin issue #2863: Hotfix: ambiguous reference to overloaded definition
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2863
LGTM
---
[GitHub] zeppelin pull request #2863: Hotfix: ambiguous reference to overloaded defin...
Posted by necosta <gi...@git.apache.org>.
GitHub user necosta reopened a pull request:
https://github.com/apache/zeppelin/pull/2863
Hotfix: ambiguous reference to overloaded definition
### What is this PR for?
Minor bugfix on Zeppelin build from sources
### What type of PR is it?
Bug Fix
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3324
### How should this be tested?
* mvn clean package \
--batch-mode package \
-Phelium-dev \
-Pscala-2.11 \
-Dscala.version=2.11.8 \
-Dscala.binary.version=2.11 \
-Pbuild-distr \
-Pspark-2.1 \
-Dspark.version=2.1.1 \
-Pr \
-Pcassandra-spark-1.5 \
-Psparkr \
-Ppyspark \
-Phadoop-2.7 \
-Dhadoop.version=2.7.3 \
-Dmaven.findbugs.enable=false \
-Drat.skip=true \
-Dcheckstyle.skip=true \
-DskipTests
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin ZEPPELIN-3324
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2863.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2863
----
commit 05801930c4b7406bae34f340af7294242a941f24
Author: Nelson Costa <ne...@...>
Date: 2018-03-07T14:58:26Z
Hotfix: ambiguous reference to overloaded definition
----
---
[GitHub] zeppelin pull request #2863: Hotfix: ambiguous reference to overloaded defin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2863
---
[GitHub] zeppelin issue #2863: Hotfix: ambiguous reference to overloaded definition
Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2863
Green CI (https://travis-ci.org/nokia/zeppelin/builds/352915331)
Adding main contributors for review: @Leemoonsoo , @zjffdu
Thanks
---
[GitHub] zeppelin pull request #2863: Hotfix: ambiguous reference to overloaded defin...
Posted by necosta <gi...@git.apache.org>.
Github user necosta closed the pull request at:
https://github.com/apache/zeppelin/pull/2863
---
[GitHub] zeppelin issue #2863: Hotfix: ambiguous reference to overloaded definition
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2863
Thanks for contribution @necosta and sorry for late response, will merge it soon
---
[GitHub] zeppelin pull request #2863: Hotfix: ambiguous reference to overloaded defin...
Posted by necosta <gi...@git.apache.org>.
Github user necosta closed the pull request at:
https://github.com/apache/zeppelin/pull/2863
---