You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/23 01:33:43 UTC

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4420: Including instance details in KubernetesClusterResponse

GabrielBrascher commented on a change in pull request #4420:
URL: https://github.com/apache/cloudstack/pull/4420#discussion_r510546513



##########
File path: plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java
##########
@@ -606,13 +610,20 @@ public KubernetesClusterResponse createKubernetesClusterResponse(long kubernetes
         response.setEndpoint(kubernetesCluster.getEndpoint());
         response.setNetworkId(ntwk.getUuid());
         response.setAssociatedNetworkName(ntwk.getName());
-        List<String> vmIds = new ArrayList<String>();
+        List<UserVmResponse> vmIds = new ArrayList<UserVmResponse>();

Review comment:
       @davidjumani considering that this variable has changed from a list of _VM IDs_ to a list of _VM Responses_ I would suggest renaming it.
   What do you think of _vmResponses_ or _vmResponseList_?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org