You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2022/05/04 15:28:00 UTC
[jira] [Commented] (SOLR-14699) Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)
[ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531788#comment-17531788 ]
David Smiley commented on SOLR-14699:
-------------------------------------
[~jbernste] not sure if you have an opinion here. I ask because you've worked on the SolrLogPostTool that parses these logs.
My preference is _conditional_ quoted string; use JSON spec & utils to do the actual work. Yeah; it'd mean encoding & parsing is a little more interesting but preserves conciseness, especially given that Solr's standard/default values don't need any escaping; at least not yet but I could see this changing in a new issue soon. We all see these logs whenever we use Solr, so conciseness has some virtue.
> Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)
> ----------------------------------------------------------------------------------
>
> Key: SOLR-14699
> URL: https://issues.apache.org/jira/browse/SOLR-14699
> Project: Solr
> Issue Type: Improvement
> Components: logging
> Reporter: David Smiley
> Priority: Minor
>
> {{SolrQueryResponse.getToLogAsString}} encodes the NamedList into a String with simple space-separated pairs with name=value. However, it does no escaping/encoding, and as-such a value might itself contain spaces and equals. This is a problem if these logs are being parsed, and we'd like to ensure we do so correctly. Note that SolrLogPostTool (aka "postlogs") parses these logs.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org