You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (JIRA)" <ji...@apache.org> on 2011/09/07 17:44:11 UTC
[jira] [Created] (CASSANDRA-3148) Use TreeMap backed column
families for the SSTable simple writers
Use TreeMap backed column families for the SSTable simple writers
-----------------------------------------------------------------
Key: CASSANDRA-3148
URL: https://issues.apache.org/jira/browse/CASSANDRA-3148
Project: Cassandra
Issue Type: Improvement
Components: Core
Affects Versions: 1.0
Reporter: Sylvain Lebresne
Assignee: Sylvain Lebresne
Priority: Trivial
Fix For: 1.0
Attachments: 0001-Use-TreeMap-for-SSTable-simple-writers-CFs.patch
SSTable*SimpleWriter classes are not intended to be used concurrently (and indeed they are not thread safe), so there is no point in using CLSM backed column families.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3148) Use TreeMap backed column
families for the SSTable simple writers
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099175#comment-13099175 ]
Hudson commented on CASSANDRA-3148:
-----------------------------------
Integrated in Cassandra #1083 (See [https://builds.apache.org/job/Cassandra/1083/])
Use TreeMap backed column families for the SSTable simple writers
patch by slebresne; reviewed by jbellis for CASSANDRA-3148
slebresne : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166283
Files :
* /cassandra/trunk/CHANGES.txt
* /cassandra/trunk/src/java/org/apache/cassandra/db/ArrayBackedSortedColumns.java
* /cassandra/trunk/src/java/org/apache/cassandra/db/ColumnFamilySerializer.java
* /cassandra/trunk/src/java/org/apache/cassandra/db/ReadResponse.java
* /cassandra/trunk/src/java/org/apache/cassandra/db/Row.java
* /cassandra/trunk/src/java/org/apache/cassandra/db/RowMutation.java
* /cassandra/trunk/src/java/org/apache/cassandra/db/ThreadSafeSortedColumns.java
* /cassandra/trunk/src/java/org/apache/cassandra/db/TreeMapBackedSortedColumns.java
* /cassandra/trunk/src/java/org/apache/cassandra/io/sstable/SSTableSimpleUnsortedWriter.java
* /cassandra/trunk/src/java/org/apache/cassandra/io/sstable/SSTableSimpleWriter.java
* /cassandra/trunk/src/java/org/apache/cassandra/io/sstable/SSTableWriter.java
* /cassandra/trunk/test/unit/org/apache/cassandra/db/ArrayBackedSortedColumnsTest.java
> Use TreeMap backed column families for the SSTable simple writers
> -----------------------------------------------------------------
>
> Key: CASSANDRA-3148
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3148
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.0
>
> Attachments: 0001-Use-TreeMap-for-SSTable-simple-writers-CFs.patch
>
>
> SSTable*SimpleWriter classes are not intended to be used concurrently (and indeed they are not thread safe), so there is no point in using CLSM backed column families.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3148) Use TreeMap backed column
families for the SSTable simple writers
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099109#comment-13099109 ]
Jonathan Ellis commented on CASSANDRA-3148:
-------------------------------------------
wfm.
> Use TreeMap backed column families for the SSTable simple writers
> -----------------------------------------------------------------
>
> Key: CASSANDRA-3148
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3148
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.0
>
> Attachments: 0001-Use-TreeMap-for-SSTable-simple-writers-CFs.patch
>
>
> SSTable*SimpleWriter classes are not intended to be used concurrently (and indeed they are not thread safe), so there is no point in using CLSM backed column families.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3148) Use TreeMap backed column
families for the SSTable simple writers
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099059#comment-13099059 ]
Jonathan Ellis commented on CASSANDRA-3148:
-------------------------------------------
can we make a AbstractMapBackedSortedColumns or something so we reduce code duplication?
nit: not a fan of capitalizing final non-primitive objects as in FACTORY
> Use TreeMap backed column families for the SSTable simple writers
> -----------------------------------------------------------------
>
> Key: CASSANDRA-3148
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3148
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.0
>
> Attachments: 0001-Use-TreeMap-for-SSTable-simple-writers-CFs.patch
>
>
> SSTable*SimpleWriter classes are not intended to be used concurrently (and indeed they are not thread safe), so there is no point in using CLSM backed column families.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3148) Use TreeMap backed column
families for the SSTable simple writers
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-3148:
----------------------------------------
Attachment: 0001-Use-TreeMap-for-SSTable-simple-writers-CFs.patch
Patch add TreeMapBackedSortedColumns and use that for the SSTable simple writers.
> Use TreeMap backed column families for the SSTable simple writers
> -----------------------------------------------------------------
>
> Key: CASSANDRA-3148
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3148
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.0
>
> Attachments: 0001-Use-TreeMap-for-SSTable-simple-writers-CFs.patch
>
>
> SSTable*SimpleWriter classes are not intended to be used concurrently (and indeed they are not thread safe), so there is no point in using CLSM backed column families.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3148) Use TreeMap backed column
families for the SSTable simple writers
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099074#comment-13099074 ]
Sylvain Lebresne commented on CASSANDRA-3148:
---------------------------------------------
bq. can we make a AbstractMapBackedSortedColumns or something so we reduce code duplication?
We could, but we would have to change ThreadSafeSortedColumns and TreeMapBackedSortedColumns because they are using extension right now. Which was done to avoid some object allocation. Now I know, you'll say that this is exactly the kind of reason why you advocated using wrapping instead of extension back then on CASSANDRA-2843. And you would be right to say it. However, at least for now, there is not so much duplication: all the factory stuff can't be factored and the add/replace methods differ, so it is only a bunch of one line method. I would propose to stick to extension for now until some other change make an abstract class more worth it. But I won't fight for that if there is strong feeling involved against that.
bq. nit: not a fan of capitalizing final non-primitive objects as in FACTORY
Yeah, and it's true we don't do that in the code base. I'll lowercase all those (while committing if not sooner).
> Use TreeMap backed column families for the SSTable simple writers
> -----------------------------------------------------------------
>
> Key: CASSANDRA-3148
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3148
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.0
>
> Attachments: 0001-Use-TreeMap-for-SSTable-simple-writers-CFs.patch
>
>
> SSTable*SimpleWriter classes are not intended to be used concurrently (and indeed they are not thread safe), so there is no point in using CLSM backed column families.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira