You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/12 01:52:32 UTC
[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1031: fix(plugin): set disable but useless
juzhiyuan opened a new pull request #1031:
URL: https://github.com/apache/apisix-dashboard/pull/1031
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
fix #1027
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1031: fix(plugin): set disable but useless
Posted by GitBox <gi...@apache.org>.
LiteSun commented on pull request #1031:
URL: https://github.com/apache/apisix-dashboard/pull/1031#issuecomment-743665074
CI failed @juzhiyuan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1031: fix(plugin): set disable but useless
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1031:
URL: https://github.com/apache/apisix-dashboard/pull/1031#issuecomment-743690940
There has something I need to confirm with the backend, just wait.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1031: fix(plugin): set disable but useless
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1031:
URL: https://github.com/apache/apisix-dashboard/pull/1031#issuecomment-743695231
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1031?src=pr&el=h1) Report
> Merging [#1031](https://codecov.io/gh/apache/apisix-dashboard/pull/1031?src=pr&el=desc) (b64509c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/edd02bcd4832289638455dde1cb5830d81a0182e?el=desc) (edd02bc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1031 +/- ##
=======================================
Coverage 40.13% 40.13%
=======================================
Files 26 26
Lines 1572 1572
=======================================
Hits 631 631
Misses 850 850
Partials 91 91
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1031?src=pr&el=footer). Last update [edd02bc...b64509c](https://codecov.io/gh/apache/apisix-dashboard/pull/1031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis merged pull request #1031: fix(plugin): set disable but useless
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1031:
URL: https://github.com/apache/apisix-dashboard/pull/1031
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1031: fix(plugin): set disable but useless
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1031:
URL: https://github.com/apache/apisix-dashboard/pull/1031#issuecomment-743680473
> CI failed @juzhiyuan
cc @nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1031: fix(plugin): set disable but useless
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1031:
URL: https://github.com/apache/apisix-dashboard/pull/1031#issuecomment-743695231
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1031?src=pr&el=h1) Report
> Merging [#1031](https://codecov.io/gh/apache/apisix-dashboard/pull/1031?src=pr&el=desc) (415b6f7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/edd02bcd4832289638455dde1cb5830d81a0182e?el=desc) (edd02bc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1031 +/- ##
=======================================
Coverage 40.13% 40.13%
=======================================
Files 26 26
Lines 1572 1572
=======================================
Hits 631 631
Misses 850 850
Partials 91 91
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1031?src=pr&el=footer). Last update [edd02bc...415b6f7](https://codecov.io/gh/apache/apisix-dashboard/pull/1031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org