You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2012/06/28 20:51:44 UTC
[jira] [Created] (HBASE-6291) Don't retry increments on an invalid
cell
Jean-Daniel Cryans created HBASE-6291:
-----------------------------------------
Summary: Don't retry increments on an invalid cell
Key: HBASE-6291
URL: https://issues.apache.org/jira/browse/HBASE-6291
Project: HBase
Issue Type: Improvement
Affects Versions: 0.94.0, 0.92.1, 0.90.6
Reporter: Jean-Daniel Cryans
Fix For: 0.90.7, 0.92.2, 0.94.1
This says it all:
{noformat}
ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
{noformat}
{{HRegion}} should be modified here to send a DoNotRetryIOException:
{code}
if (wrongLength) {
throw new DoNotRetryIOException(
"Attempted to increment field that isn't 64 bits wide");
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6291) Don't retry increments on an
invalid cell
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445189#comment-13445189 ]
Hadoop QA commented on HBASE-6291:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12543139/6291-0.96-v4.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2741//console
This message is automatically generated.
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6291-0.94.txt, 6291-0.96.txt, 6291-0.96-v2.txt, 6291-0.96-v3.txt, 6291-0.96-v4.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6291) Don't retry increments on an invalid
cell
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-6291:
---------------------------------
Attachment: 6291-0.96-v2.txt
Trunk patch with test. Also fixes Increment.
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6291-0.96.txt, 6291-0.96-v2.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6291) Don't retry increments on an
invalid cell
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448266#comment-13448266 ]
Hudson commented on HBASE-6291:
-------------------------------
Integrated in HBase-0.94-security #51 (See [https://builds.apache.org/job/HBase-0.94-security/51/])
HBASE-6291 Don't retry increments on an invalid cell (Revision 1379076)
Result = FAILURE
larsh :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6291-0.94.txt, 6291-0.96.txt, 6291-0.96-v2.txt, 6291-0.96-v3.txt, 6291-0.96-v4.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6291) Don't retry increments on an
invalid cell
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445108#comment-13445108 ]
Jean-Daniel Cryans commented on HBASE-6291:
-------------------------------------------
I think for sake of completeness that testIncrementingInvalidValue should fail if no exception is thrown.
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6291-0.94.txt, 6291-0.96.txt, 6291-0.96-v2.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6291) Don't retry increments on an invalid
cell
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-6291:
---------------------------------
Fix Version/s: (was: 0.94.1)
0.94.2
I don't think it is important to have this in 0.94.1. Please pull back if you disagree.
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Fix For: 0.90.7, 0.92.2, 0.94.2
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6291) Don't retry increments on an
invalid cell
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444530#comment-13444530 ]
Lars Hofhansl commented on HBASE-6291:
--------------------------------------
It's a bit more work. In trunk Increment is always used, and Increment does not perform that length check before calling Bytes.toLong, hence IllegalArgumentException is thrown and the operation is retried.
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6291-0.96.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6291) Don't retry increments on an invalid
cell
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-6291:
---------------------------------
Fix Version/s: (was: 0.90.8)
(was: 0.92.2)
0.96.0
Targeting for 0.94 and 0.96. Please speak up if you want this in 0.92 or before.
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6291-0.96.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6291) Don't retry increments on an
invalid cell
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442522#comment-13442522 ]
Jean-Daniel Cryans commented on HBASE-6291:
-------------------------------------------
Yes +1
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.92.2, 0.94.2, 0.90.8
>
> Attachments: 6291-0.96.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6291) Don't retry increments on an
invalid cell
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445615#comment-13445615 ]
Hudson commented on HBASE-6291:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #155 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/155/])
HBASE-6291 Don't retry increments on an invalid cell (Revision 1379058)
Result = FAILURE
larsh :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6291-0.94.txt, 6291-0.96.txt, 6291-0.96-v2.txt, 6291-0.96-v3.txt, 6291-0.96-v4.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6291) Don't retry increments on an invalid
cell
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-6291:
----------------------------------
Fix Version/s: (was: 0.90.7)
0.90.8
bumping from 0.90.7
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Fix For: 0.92.2, 0.94.2, 0.90.8
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6291) Don't retry increments on an
invalid cell
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444587#comment-13444587 ]
Hadoop QA commented on HBASE-6291:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12543011/6291-0.94.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2733//console
This message is automatically generated.
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6291-0.94.txt, 6291-0.96.txt, 6291-0.96-v2.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6291) Don't retry increments on an
invalid cell
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404554#comment-13404554 ]
Lars Hofhansl commented on HBASE-6291:
--------------------------------------
Wanna make a patch J-D?
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Fix For: 0.90.7, 0.92.2, 0.94.1
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6291) Don't retry increments on an
invalid cell
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445643#comment-13445643 ]
Hudson commented on HBASE-6291:
-------------------------------
Integrated in HBase-0.94 #443 (See [https://builds.apache.org/job/HBase-0.94/443/])
HBASE-6291 Don't retry increments on an invalid cell (Revision 1379076)
Result = SUCCESS
larsh :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6291-0.94.txt, 6291-0.96.txt, 6291-0.96-v2.txt, 6291-0.96-v3.txt, 6291-0.96-v4.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6291) Don't retry increments on an
invalid cell
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444585#comment-13444585 ]
Hadoop QA commented on HBASE-6291:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12543009/6291-0.96-v2.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
-1 javadoc. The javadoc tool appears to have generated 110 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2731//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2731//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2731//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2731//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2731//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2731//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2731//console
This message is automatically generated.
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6291-0.94.txt, 6291-0.96.txt, 6291-0.96-v2.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6291) Don't retry increments on an
invalid cell
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445084#comment-13445084 ]
Lars Hofhansl commented on HBASE-6291:
--------------------------------------
Planning to commit today.
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6291-0.94.txt, 6291-0.96.txt, 6291-0.96-v2.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6291) Don't retry increments on an invalid
cell
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-6291:
---------------------------------
Attachment: 6291-0.94.txt
And a 0.94 patch.
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6291-0.94.txt, 6291-0.96.txt, 6291-0.96-v2.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6291) Don't retry increments on an invalid
cell
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-6291:
---------------------------------
Attachment: 6291-0.96-v4.txt
What I committed to trunk
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6291-0.94.txt, 6291-0.96.txt, 6291-0.96-v2.txt, 6291-0.96-v3.txt, 6291-0.96-v4.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6291) Don't retry increments on an
invalid cell
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448355#comment-13448355 ]
Hudson commented on HBASE-6291:
-------------------------------
Integrated in HBase-0.94-security-on-Hadoop-23 #7 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/7/])
HBASE-6291 Don't retry increments on an invalid cell (Revision 1379076)
Result = FAILURE
larsh :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6291-0.94.txt, 6291-0.96.txt, 6291-0.96-v2.txt, 6291-0.96-v3.txt, 6291-0.96-v4.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6291) Don't retry increments on an
invalid cell
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445121#comment-13445121 ]
Jean-Daniel Cryans commented on HBASE-6291:
-------------------------------------------
+1
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6291-0.94.txt, 6291-0.96.txt, 6291-0.96-v2.txt, 6291-0.96-v3.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6291) Don't retry increments on an invalid
cell
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-6291:
---------------------------------
Attachment: 6291-0.96-v3.txt
Fair enough. Updated patch.
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6291-0.94.txt, 6291-0.96.txt, 6291-0.96-v2.txt, 6291-0.96-v3.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6291) Don't retry increments on an
invalid cell
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405433#comment-13405433 ]
Jean-Daniel Cryans commented on HBASE-6291:
-------------------------------------------
Yeah it's not a blocker and at the moment I have 0 spare time to work on it.
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Fix For: 0.90.7, 0.92.2, 0.94.2
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6291) Don't retry increments on an invalid
cell
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-6291:
---------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to 0.94 and 0.96
> Don't retry increments on an invalid cell
> -----------------------------------------
>
> Key: HBASE-6291
> URL: https://issues.apache.org/jira/browse/HBASE-6291
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0
> Reporter: Jean-Daniel Cryans
> Assignee: Lars Hofhansl
> Fix For: 0.96.0, 0.94.2
>
> Attachments: 6291-0.94.txt, 6291-0.96.txt, 6291-0.96-v2.txt, 6291-0.96-v3.txt, 6291-0.96-v4.txt
>
>
> This says it all:
> {noformat}
> ERROR: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=7, exceptions:
> Thu Jun 28 18:34:44 UTC 2012, org.apache.hadoop.hbase.client.HTable$8@4eabaf8c, java.io.IOException: java.io.IOException: Attempted to increment field that isn't 64 bits wide
> {noformat}
> {{HRegion}} should be modified here to send a DoNotRetryIOException:
> {code}
> if (wrongLength) {
> throw new DoNotRetryIOException(
> "Attempted to increment field that isn't 64 bits wide");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira