You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "lukaszzborek (via GitHub)" <gi...@apache.org> on 2026/03/20 16:38:20 UTC
[PR] refactor(csharp): rename asynchronous methods to have Async suffix [iggy]
lukaszzborek opened a new pull request, #2994:
URL: https://github.com/apache/iggy/pull/2994
- rename async methods to have Async suffix (a few methods didn't have it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(csharp): rename asynchronous methods to have Async suffix [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio merged PR #2994:
URL: https://github.com/apache/iggy/pull/2994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(csharp): rename asynchronous methods to have Async suffix [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2994:
URL: https://github.com/apache/iggy/pull/2994#issuecomment-4103103001
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/2994?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `14 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.68%. Comparing base ([`50557dc`](https://app.codecov.io/gh/apache/iggy/commit/50557dcefc7cae301c1e8616d7836c387b0aa287?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ce2fb3b`](https://app.codecov.io/gh/apache/iggy/commit/ce2fb3bb9e0ba40f2296821cc7b1ebca402fe8ed?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/2994?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [foreign/csharp/Iggy\_SDK/Consumers/IggyConsumer.cs](https://app.codecov.io/gh/apache/iggy/pull/2994?src=pr&el=tree&filepath=foreign%2Fcsharp%2FIggy_SDK%2FConsumers%2FIggyConsumer.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9jc2hhcnAvSWdneV9TREsvQ29uc3VtZXJzL0lnZ3lDb25zdW1lci5jcw==) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/2994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...oreign/csharp/Iggy\_SDK/Publishers/IggyPublisher.cs](https://app.codecov.io/gh/apache/iggy/pull/2994?src=pr&el=tree&filepath=foreign%2Fcsharp%2FIggy_SDK%2FPublishers%2FIggyPublisher.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9jc2hhcnAvSWdneV9TREsvUHVibGlzaGVycy9JZ2d5UHVibGlzaGVyLmNz) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/2994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...SDK/IggyClient/Implementations/TcpMessageStream.cs](https://app.codecov.io/gh/apache/iggy/pull/2994?src=pr&el=tree&filepath=foreign%2Fcsharp%2FIggy_SDK%2FIggyClient%2FImplementations%2FTcpMessageStream.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9jc2hhcnAvSWdneV9TREsvSWdneUNsaWVudC9JbXBsZW1lbnRhdGlvbnMvVGNwTWVzc2FnZVN0cmVhbS5jcw==) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/2994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ign/csharp/Iggy\_SDK/Publishers/IggyPublisherOfT.cs](https://app.codecov.io/gh/apache/iggy/pull/2994?src=pr&el=tree&filepath=foreign%2Fcsharp%2FIggy_SDK%2FPublishers%2FIggyPublisherOfT.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9jc2hhcnAvSWdneV9TREsvUHVibGlzaGVycy9JZ2d5UHVibGlzaGVyT2ZULmNz) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/2994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
:x: Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the [target](https://docs.codecov.com/docs/commit-status#target) coverage.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2994 +/- ##
============================================
- Coverage 71.88% 68.68% -3.21%
Complexity 930 930
============================================
Files 1117 1117
Lines 92952 92952
Branches 70474 70485 +11
============================================
- Hits 66815 63840 -2975
- Misses 23577 26750 +3173
+ Partials 2560 2362 -198
```
| [Flag](https://app.codecov.io/gh/apache/iggy/pull/2994/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [csharp](https://app.codecov.io/gh/apache/iggy/pull/2994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `12.59% <0.00%> (-55.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/2994?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...sharp/Iggy\_SDK/Contracts/Auth/GlobalPermissions.cs](https://app.codecov.io/gh/apache/iggy/pull/2994?src=pr&el=tree&filepath=foreign%2Fcsharp%2FIggy_SDK%2FContracts%2FAuth%2FGlobalPermissions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9jc2hhcnAvSWdneV9TREsvQ29udHJhY3RzL0F1dGgvR2xvYmFsUGVybWlzc2lvbnMuY3M=) | `0.00% <ø> (-100.00%)` | :arrow_down: |
| [...DK/IggyClient/Implementations/HttpMessageStream.cs](https://app.codecov.io/gh/apache/iggy/pull/2994?src=pr&el=tree&filepath=foreign%2Fcsharp%2FIggy_SDK%2FIggyClient%2FImplementations%2FHttpMessageStream.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9jc2hhcnAvSWdneV9TREsvSWdneUNsaWVudC9JbXBsZW1lbnRhdGlvbnMvSHR0cE1lc3NhZ2VTdHJlYW0uY3M=) | `0.00% <ø> (-71.73%)` | :arrow_down: |
| [...SDK/IggyClient/Implementations/TcpMessageStream.cs](https://app.codecov.io/gh/apache/iggy/pull/2994?src=pr&el=tree&filepath=foreign%2Fcsharp%2FIggy_SDK%2FIggyClient%2FImplementations%2FTcpMessageStream.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9jc2hhcnAvSWdneV9TREsvSWdneUNsaWVudC9JbXBsZW1lbnRhdGlvbnMvVGNwTWVzc2FnZVN0cmVhbS5jcw==) | `0.00% <0.00%> (-76.34%)` | :arrow_down: |
| [...ign/csharp/Iggy\_SDK/Publishers/IggyPublisherOfT.cs](https://app.codecov.io/gh/apache/iggy/pull/2994?src=pr&el=tree&filepath=foreign%2Fcsharp%2FIggy_SDK%2FPublishers%2FIggyPublisherOfT.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9jc2hhcnAvSWdneV9TREsvUHVibGlzaGVycy9JZ2d5UHVibGlzaGVyT2ZULmNz) | `0.00% <0.00%> (ø)` | |
| [foreign/csharp/Iggy\_SDK/Consumers/IggyConsumer.cs](https://app.codecov.io/gh/apache/iggy/pull/2994?src=pr&el=tree&filepath=foreign%2Fcsharp%2FIggy_SDK%2FConsumers%2FIggyConsumer.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9jc2hhcnAvSWdneV9TREsvQ29uc3VtZXJzL0lnZ3lDb25zdW1lci5jcw==) | `0.00% <0.00%> (-62.00%)` | :arrow_down: |
| [...oreign/csharp/Iggy\_SDK/Publishers/IggyPublisher.cs](https://app.codecov.io/gh/apache/iggy/pull/2994?src=pr&el=tree&filepath=foreign%2Fcsharp%2FIggy_SDK%2FPublishers%2FIggyPublisher.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm9yZWlnbi9jc2hhcnAvSWdneV9TREsvUHVibGlzaGVycy9JZ2d5UHVibGlzaGVyLmNz) | `0.00% <0.00%> (-78.99%)` | :arrow_down: |
... and [78 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/2994/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org