Re: [PR] [GOBBLIN-2022] add re-evaluate dag proc [gobblin]

["phet (via GitHub)" <gi...@apache.org>]

phet commented on code in PR #3896:
URL: https://github.com/apache/gobblin/pull/3896#discussion_r1538010430


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagTaskVisitor.java:
##########
@@ -18,8 +18,10 @@
 package org.apache.gobblin.service.modules.orchestration;
 
 import org.apache.gobblin.service.modules.orchestration.task.LaunchDagTask;
+import org.apache.gobblin.service.modules.orchestration.task.ReEvaluateDagTask;
 
 
 public interface DagTaskVisitor<T> {
   T meet(LaunchDagTask launchDagTask);
+  T meet(ReEvaluateDagTask launchDagTask);

Review Comment:
   not `launchDagTask`



##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -114,8 +115,10 @@ private DagTask createDagTask(DagActionStore.DagAction dagAction, MultiActiveLea
     switch (dagActionType) {
       case LAUNCH:
         return new LaunchDagTask(dagAction, leaseObtainedStatus);
+      case REEVALUATE:
+        return new ReEvaluateDagTask(dagAction, leaseObtainedStatus);

Review Comment:
   since "reevaluate"/"Reevaluate" (capitalized), let's spell `ReevaluateDagTask`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org