[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8469: ARROW-10122: [Python] Fix to_pandas conversion with subset of columns and MultiIndex

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on a change in pull request #8469:
URL: https://github.com/apache/arrow/pull/8469#discussion_r505512669



##########
File path: python/pyarrow/pandas_compat.py
##########
@@ -966,7 +966,7 @@ def _extract_index_level(table, result_table, field_name,
 
     if i == -1:
         # The serialized index column was removed by the user
-        return table, None, None
+        return result_table, None, None

Review comment:
       So as long as this method was called once or columns were not missing, this was fine. But if an index column was missing after another index column was already converted to an Index and removed from `result_table`, then `table` and `result_table` is no longer the same.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org