You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Nuutti Kotivuori <na...@iki.fi> on 2002/06/22 21:40:23 UTC
Re: [PATCH] Generate ISO-8601 dates and canonicalize dates on
'svnadmin dump' - PROBLEM
Nuutti Kotivuori wrote:
> So, this is a patch that makes subversion generate ISO-8601 - and
> canonicalize dates to that format on 'svnadmin dump'. So to make all
> dates in the repository ISO-8601, a dump & load is needed.
>
> Quick review round, just in case, and then commit.
There's a small problem. If I commit this now, 'svn log' output will be:
rev 2309: kfogel | 2002-06-22T09:14:58 | 16 lines
^^^^^^^^^^^^^^^^^^^
This would ofcourse be fixed when I commit the other patch which
corrects the date display for humans. But depending on things, getting
that patch in might take some time (with all the debate on date
formats) - but I would not wish to delay the usage of ISO-8601 on the
repository side.
Just to let you know.
-- Naked
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Generate ISO-8601 dates and canonicalize dates on
'svnadmin dump' - PROBLEM
Posted by Nuutti Kotivuori <na...@iki.fi>.
Greg Stein wrote:
> Actually, this won't happen if you fix one thing, which is currently
> broken today. The svn_log_message_receiver_t type is passing times
> using a string. Instead, it should pass times using apr_time_t, in
> GMT values.
Ah! Exactly! I'll go rumble around the code for that.
> My advice is to apply your patches immediately, but to leave the
> "human" format as what we have today. That will get the *structural*
> changes into the code quickly. Then, when the discussion is settled,
> then you'll only have one piece of code to tweak. This also means
> that your patch won't go stale while the discussion proceeds.
Sounds good, except that I'm going to propose yet another format in
the mean time - and hope it doesn't get any -1's.
-- Naked
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Generate ISO-8601 dates and canonicalize dates on 'svnadmin dump' - PROBLEM
Posted by Greg Stein <gs...@lyra.org>.
On Sun, Jun 23, 2002 at 12:40:23AM +0300, Nuutti Kotivuori wrote:
> Nuutti Kotivuori wrote:
> > So, this is a patch that makes subversion generate ISO-8601 - and
> > canonicalize dates to that format on 'svnadmin dump'. So to make all
> > dates in the repository ISO-8601, a dump & load is needed.
> >
> > Quick review round, just in case, and then commit.
>
> There's a small problem. If I commit this now, 'svn log' output will be:
>
> rev 2309: kfogel | 2002-06-22T09:14:58 | 16 lines
> ^^^^^^^^^^^^^^^^^^^
>
> This would ofcourse be fixed when I commit the other patch which
> corrects the date display for humans. But depending on things, getting
Actually, this won't happen if you fix one thing, which is currently broken
today. The svn_log_message_receiver_t type is passing times using a string.
Instead, it should pass times using apr_time_t, in GMT values.
Thus, when 'svn log' is run, a time will be passed via the receiver
function, and then the appropriate time formatting function will be used.
Whether that is svn_time_to_nts() or svn_time_human_whatever(), then the
correct thing will be printed.
With this change, then you can go ahead and make svnadmin dump/load use
ISO8601 dates. (there should be no controversy there!)
> that patch in might take some time (with all the debate on date
> formats) - but I would not wish to delay the usage of ISO-8601 on the
> repository side.
My advice is to apply your patches immediately, but to leave the "human"
format as what we have today. That will get the *structural* changes into
the code quickly. Then, when the discussion is settled, then you'll only
have one piece of code to tweak. This also means that your patch won't go
stale while the discussion proceeds.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Generate ISO-8601 dates and canonicalize dates on 'svnadmin dump' - PROBLEM
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Nuutti Kotivuori <na...@iki.fi> writes:
> There's a small problem. If I commit this now, 'svn log' output will be:
>
> rev 2309: kfogel | 2002-06-22T09:14:58 | 16 lines
> ^^^^^^^^^^^^^^^^^^^
>
> This would ofcourse be fixed when I commit the other patch which
> corrects the date display for humans. But depending on things, getting
> that patch in might take some time (with all the debate on date
> formats) - but I would not wish to delay the usage of ISO-8601 on the
> repository side.
>
> Just to let you know.
Why not commit both patches, and then commit tweaks to the
human-readable strings after discussions?
(If not, then I'd say wait on the repos stuff.)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org