You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/06/06 07:23:02 UTC

[GitHub] rhtyd commented on a change in pull request #2683: Add default L2 network offerings

rhtyd commented on a change in pull request #2683: Add default L2 network offerings
URL: https://github.com/apache/cloudstack/pull/2683#discussion_r193314481
 
 

 ##########
 File path: engine/schema/src/com/cloud/offerings/dao/NetworkOfferingDaoImpl.java
 ##########
 @@ -221,4 +224,41 @@ public boolean isUsingServicePackage(String uuid) {
 
         return false;
     }
+
+    @Override
+    public void persistDefaultL2NetworkOfferings() {
 
 Review comment:
   @nvazquez my understanding is that the default network offerings will be added only for new environments? How do we handle upgrades, or if this will take care of existing environments as well, in which case should we check and update (i.e. if offerings already exist, don't add them?).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services