You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "advancedxy (via GitHub)" <gi...@apache.org> on 2023/02/07 13:06:12 UTC

[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #555: [#554] feat: infer rss base storage conf from env

advancedxy commented on code in PR #555:
URL: https://github.com/apache/incubator-uniffle/pull/555#discussion_r1098635263


##########
common/src/test/java/org/apache/uniffle/common/util/RssUtilsTest.java:
##########
@@ -177,6 +181,24 @@ public void testGenerateServerToPartitions() {
     assertEquals(serverToPartitions.get(server4), Sets.newHashSet(2, 4));
   }
 
+  @Test
+  public void testGetConfiguredLocalDirs() {
+    RssConf conf = new RssConf();
+    withEnv(RssUtils.RSS_LOCAL_DIR_KEY, "/path/a", () -> {

Review Comment:
   I would argue that these 'two things' are tightly related and it's not that much to review. 
   It would be better to split into two prs and I believe one should be totally fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org