You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Alexandr Smirnov (JIRA)" <my...@incubator.apache.org> on 2005/09/05 11:21:30 UTC
[jira] Created: (MYFACES-505) Use writeComment() instead of write() for
Use writeComment() instead of write() for <script>
--------------------------------------------------
Key: MYFACES-505
URL: http://issues.apache.org/jira/browse/MYFACES-505
Project: MyFaces
Type: Improvement
Components: Implementation
Environment: ALL
Reporter: Alexandr Smirnov
Priority: Minor
For creating in-page scripts, MyFaces implementation use RsponceWriter.write() method with "<!-- " and "-->" strings. It not important in HTML_BASIC , but may produce troubles for creating XHTML output in future ( in most cases, all correct writed components can produce valid XHTML. ). For such reasons, more correct will be use ResponseWriter.writeComment method for scripts & styles. In implementation, single place for in-page script prodution - renderClearHiddenCommandFormParamsFunction in HtmlRendererUtils.
attached patch replace write to writeComment for this function.
Also, in Tomahawk components have many places for commented scripts & styles.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-505) Use writeComment() instead of write() for
Posted by "Alexandr Smirnov (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-505?page=all ]
Alexandr Smirnov updated MYFACES-505:
-------------------------------------
Attachment: HtmlRendererUtils.patch
> Use writeComment() instead of write() for <script>
> --------------------------------------------------
>
> Key: MYFACES-505
> URL: http://issues.apache.org/jira/browse/MYFACES-505
> Project: MyFaces
> Type: Improvement
> Components: Implementation
> Environment: ALL
> Reporter: Alexandr Smirnov
> Priority: Minor
> Attachments: HtmlRendererUtils.patch
>
> For creating in-page scripts, MyFaces implementation use RsponceWriter.write() method with "<!-- " and "-->" strings. It not important in HTML_BASIC , but may produce troubles for creating XHTML output in future ( in most cases, all correct writed components can produce valid XHTML. ). For such reasons, more correct will be use ResponseWriter.writeComment method for scripts & styles. In implementation, single place for in-page script prodution - renderClearHiddenCommandFormParamsFunction in HtmlRendererUtils.
> attached patch replace write to writeComment for this function.
> Also, in Tomahawk components have many places for commented scripts & styles.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-505) Use writeComment() instead of write() for
Posted by "Martin Marinschek (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-505?page=comments#action_12322649 ]
Martin Marinschek commented on MYFACES-505:
-------------------------------------------
You are right - thanks for the patch. Even though this issue is a duplicate of MYFACES-158. Let's apply the patch and then close this out as duplicate!
regards,
Martin
> Use writeComment() instead of write() for <script>
> --------------------------------------------------
>
> Key: MYFACES-505
> URL: http://issues.apache.org/jira/browse/MYFACES-505
> Project: MyFaces
> Type: Improvement
> Components: Implementation
> Environment: ALL
> Reporter: Alexandr Smirnov
> Priority: Minor
> Attachments: HtmlRendererUtils.patch
>
> For creating in-page scripts, MyFaces implementation use RsponceWriter.write() method with "<!-- " and "-->" strings. It not important in HTML_BASIC , but may produce troubles for creating XHTML output in future ( in most cases, all correct writed components can produce valid XHTML. ). For such reasons, more correct will be use ResponseWriter.writeComment method for scripts & styles. In implementation, single place for in-page script prodution - renderClearHiddenCommandFormParamsFunction in HtmlRendererUtils.
> attached patch replace write to writeComment for this function.
> Also, in Tomahawk components have many places for commented scripts & styles.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-505) Use writeComment() instead of write() for
Posted by "Martin Marinschek (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-505?page=all ]
Martin Marinschek closed MYFACES-505:
-------------------------------------
Fix Version: Nightly Build
Resolution: Fixed
Thanks for this patch to Alexandr Smirnov. Also duplicate of MYFACES-158, but not the complete resolution - all scripts under tomahawk need to be changed to use this behaviour as well.
> Use writeComment() instead of write() for <script>
> --------------------------------------------------
>
> Key: MYFACES-505
> URL: http://issues.apache.org/jira/browse/MYFACES-505
> Project: MyFaces
> Type: Improvement
> Components: Implementation
> Environment: ALL
> Reporter: Alexandr Smirnov
> Assignee: Martin Marinschek
> Priority: Minor
> Fix For: Nightly Build
> Attachments: HtmlRendererUtils.patch
>
> For creating in-page scripts, MyFaces implementation use RsponceWriter.write() method with "<!-- " and "-->" strings. It not important in HTML_BASIC , but may produce troubles for creating XHTML output in future ( in most cases, all correct writed components can produce valid XHTML. ). For such reasons, more correct will be use ResponseWriter.writeComment method for scripts & styles. In implementation, single place for in-page script prodution - renderClearHiddenCommandFormParamsFunction in HtmlRendererUtils.
> attached patch replace write to writeComment for this function.
> Also, in Tomahawk components have many places for commented scripts & styles.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira