You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/31 23:01:50 UTC
[GitHub] [beam] lukecwik opened a new pull request #11280: [BEAM-9652]
Ensure that the multipartition write sets the correct coder to use instead
of relying on coder inference.
lukecwik opened a new pull request #11280: [BEAM-9652] Ensure that the multipartition write sets the correct coder to use instead of relying on coder inference.
URL: https://github.com/apache/beam/pull/11280
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik merged pull request #11280: [BEAM-9652] Ensure that
the multipartition write sets the correct coder to use instead of relying
on coder inference.
Posted by GitBox <gi...@apache.org>.
lukecwik merged pull request #11280: [BEAM-9652] Ensure that the multipartition write sets the correct coder to use instead of relying on coder inference.
URL: https://github.com/apache/beam/pull/11280
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] reuvenlax commented on a change in pull request #11280:
[BEAM-9652] Ensure that the multipartition write sets the correct coder to
use instead of relying on coder inference.
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on a change in pull request #11280: [BEAM-9652] Ensure that the multipartition write sets the correct coder to use instead of relying on coder inference.
URL: https://github.com/apache/beam/pull/11280#discussion_r401266788
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BatchLoads.java
##########
@@ -399,11 +396,9 @@ public WriteResult expandUntriggered(PCollection<KV<DestinationT, ElementT>> inp
PCollection<KV<TableDestination, String>> tempTables =
writeTempTables(partitions.get(multiPartitionsTag), loadJobIdPrefixView);
- Coder<TableDestination> tableDestinationCoder =
- clusteringEnabled ? TableDestinationCoderV3.of() : TableDestinationCoderV2.of();
tempTables
.apply("ReifyRenameInput", new ReifyAsIterable<>())
- .setCoder(IterableCoder.of(KvCoder.of(tableDestinationCoder, StringUtf8Coder.of())))
+ .setCoder(IterableCoder.of(tempTables.getCoder()))
Review comment:
I think this setCoder belongs inside the ReifyAsIterable PTransform
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11280: [BEAM-9652] Ensure that
the multipartition write sets the correct coder to use instead of relying
on coder inference.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11280: [BEAM-9652] Ensure that the multipartition write sets the correct coder to use instead of relying on coder inference.
URL: https://github.com/apache/beam/pull/11280#issuecomment-606929469
R: @reuvenlax
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11280: [BEAM-9652] Ensure that
the multipartition write sets the correct coder to use instead of relying
on coder inference.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11280: [BEAM-9652] Ensure that the multipartition write sets the correct coder to use instead of relying on coder inference.
URL: https://github.com/apache/beam/pull/11280#issuecomment-607264135
Run JavaPortabilityApi PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11280: [BEAM-9652] Ensure that
the multipartition write sets the correct coder to use instead of relying
on coder inference.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11280: [BEAM-9652] Ensure that the multipartition write sets the correct coder to use instead of relying on coder inference.
URL: https://github.com/apache/beam/pull/11280#issuecomment-607263896
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11280: [BEAM-9652] Ensure that
the multipartition write sets the correct coder to use instead of relying
on coder inference.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11280: [BEAM-9652] Ensure that the multipartition write sets the correct coder to use instead of relying on coder inference.
URL: https://github.com/apache/beam/pull/11280#issuecomment-607409511
Run JavaPortabilityApi PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on a change in pull request #11280:
[BEAM-9652] Ensure that the multipartition write sets the correct coder to
use instead of relying on coder inference.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #11280: [BEAM-9652] Ensure that the multipartition write sets the correct coder to use instead of relying on coder inference.
URL: https://github.com/apache/beam/pull/11280#discussion_r401270488
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BatchLoads.java
##########
@@ -399,11 +396,9 @@ public WriteResult expandUntriggered(PCollection<KV<DestinationT, ElementT>> inp
PCollection<KV<TableDestination, String>> tempTables =
writeTempTables(partitions.get(multiPartitionsTag), loadJobIdPrefixView);
- Coder<TableDestination> tableDestinationCoder =
- clusteringEnabled ? TableDestinationCoderV3.of() : TableDestinationCoderV2.of();
tempTables
.apply("ReifyRenameInput", new ReifyAsIterable<>())
- .setCoder(IterableCoder.of(KvCoder.of(tableDestinationCoder, StringUtf8Coder.of())))
+ .setCoder(IterableCoder.of(tempTables.getCoder()))
Review comment:
Fixed and double checked that the inputs to ReifyAsIterable are setting the correct coder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11280: [BEAM-9652] Ensure that
the multipartition write sets the correct coder to use instead of relying
on coder inference.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11280: [BEAM-9652] Ensure that the multipartition write sets the correct coder to use instead of relying on coder inference.
URL: https://github.com/apache/beam/pull/11280#issuecomment-607604862
Run JavaPortabilityApi PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services