You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Julian Reschke (Created) (JIRA)" <ji...@apache.org> on 2011/12/07 12:32:40 UTC

[jira] [Created] (JCR-3172) implement PERSIST events for the EventJournal

implement PERSIST events for the EventJournal
---------------------------------------------

                 Key: JCR-3172
                 URL: https://issues.apache.org/jira/browse/JCR-3172
             Project: Jackrabbit Content Repository
          Issue Type: Improvement
          Components: jackrabbit-core, observation
            Reporter: Julian Reschke
            Priority: Minor


See <http://www.day.com/specs/jcr/2.0/12_Observation.html#12.6.3%20Event%20Bundling%20in%20Journaled%20Observation>



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3172) implement PERSIST events for the EventJournal

Posted by "Julian Reschke (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166052#comment-13166052 ] 

Julian Reschke commented on JCR-3172:
-------------------------------------

Added <http://java.net/jira/browse/JSR_333-44> on how to filter PERSIST events.
                
> implement PERSIST events for the EventJournal
> ---------------------------------------------
>
>                 Key: JCR-3172
>                 URL: https://issues.apache.org/jira/browse/JCR-3172
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, observation
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>         Attachments: 3172.patch, JCR-3172.diff
>
>
> See <http://www.day.com/specs/jcr/2.0/12_Observation.html#12.6.3%20Event%20Bundling%20in%20Journaled%20Observation>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3172) implement PERSIST events for the EventJournal

Posted by "Julian Reschke (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Reschke updated JCR-3172:
--------------------------------

    Attachment:     (was: JCR-3172.diff)
    
> implement PERSIST events for the EventJournal
> ---------------------------------------------
>
>                 Key: JCR-3172
>                 URL: https://issues.apache.org/jira/browse/JCR-3172
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, observation
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>         Attachments: JCR-3172.diff
>
>
> See <http://www.day.com/specs/jcr/2.0/12_Observation.html#12.6.3%20Event%20Bundling%20in%20Journaled%20Observation>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3172) implement PERSIST events for the EventJournal

Posted by "Julian Reschke (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164413#comment-13164413 ] 

Julian Reschke commented on JCR-3172:
-------------------------------------

Wouldn't be EventJournalImpl the obvious place? It iterates through EventBundles and could add PERSIST each time the end of a bundle was reached..
                
> implement PERSIST events for the EventJournal
> ---------------------------------------------
>
>                 Key: JCR-3172
>                 URL: https://issues.apache.org/jira/browse/JCR-3172
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, observation
>            Reporter: Julian Reschke
>            Priority: Minor
>
> See <http://www.day.com/specs/jcr/2.0/12_Observation.html#12.6.3%20Event%20Bundling%20in%20Journaled%20Observation>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3172) implement PERSIST events for the EventJournal

Posted by "Stefan Guggisberg (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166220#comment-13166220 ] 

Stefan Guggisberg commented on JCR-3172:
----------------------------------------

+1 for the patch (JCR-3172.diff) 
                
> implement PERSIST events for the EventJournal
> ---------------------------------------------
>
>                 Key: JCR-3172
>                 URL: https://issues.apache.org/jira/browse/JCR-3172
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, observation
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>         Attachments: JCR-3172.diff
>
>
> See <http://www.day.com/specs/jcr/2.0/12_Observation.html#12.6.3%20Event%20Bundling%20in%20Journaled%20Observation>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3172) implement PERSIST events for the EventJournal

Posted by "Julian Reschke (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Reschke updated JCR-3172:
--------------------------------

    Attachment: 3172.patch

Patch, work-in-progress.

Note that the introduction of PERSIST events may cause trouble for existing EventJournal consumers, due to some method on Event now potentially returning null.
                
> implement PERSIST events for the EventJournal
> ---------------------------------------------
>
>                 Key: JCR-3172
>                 URL: https://issues.apache.org/jira/browse/JCR-3172
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, observation
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>         Attachments: 3172.patch
>
>
> See <http://www.day.com/specs/jcr/2.0/12_Observation.html#12.6.3%20Event%20Bundling%20in%20Journaled%20Observation>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3172) implement PERSIST events for the EventJournal

Posted by "Jukka Zitting (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-3172:
-------------------------------

    Fix Version/s:     (was: 2.4)
                   2.3.6
    
> implement PERSIST events for the EventJournal
> ---------------------------------------------
>
>                 Key: JCR-3172
>                 URL: https://issues.apache.org/jira/browse/JCR-3172
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, observation
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>             Fix For: 2.3.6
>
>         Attachments: JCR-3172.diff
>
>
> See <http://www.day.com/specs/jcr/2.0/12_Observation.html#12.6.3%20Event%20Bundling%20in%20Journaled%20Observation>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3172) implement PERSIST events for the EventJournal

Posted by "Stefan Guggisberg (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164460#comment-13164460 ] 

Stefan Guggisberg commented on JCR-3172:
----------------------------------------

> Wouldn't be EventJournalImpl the obvious place? It iterates through EventBundles and could add PERSIST each time the end of a bundle was reached..

yes, perhaps. i am not familiar with the details of EventJournalImpl and what the criteria of event bundling are.

anyway, EventStateCollection#createEventStates is probably the wrong place since PERSIST events should only appear in the event journal.
                
> implement PERSIST events for the EventJournal
> ---------------------------------------------
>
>                 Key: JCR-3172
>                 URL: https://issues.apache.org/jira/browse/JCR-3172
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, observation
>            Reporter: Julian Reschke
>            Priority: Minor
>
> See <http://www.day.com/specs/jcr/2.0/12_Observation.html#12.6.3%20Event%20Bundling%20in%20Journaled%20Observation>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3172) implement PERSIST events for the EventJournal

Posted by "Julian Reschke (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Reschke updated JCR-3172:
--------------------------------

    Attachment: JCR-3172.diff

Proposed patch, including fixes for spi-commons and spi2jcr
                
> implement PERSIST events for the EventJournal
> ---------------------------------------------
>
>                 Key: JCR-3172
>                 URL: https://issues.apache.org/jira/browse/JCR-3172
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, observation
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>         Attachments: 3172.patch, JCR-3172.diff
>
>
> See <http://www.day.com/specs/jcr/2.0/12_Observation.html#12.6.3%20Event%20Bundling%20in%20Journaled%20Observation>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (JCR-3172) implement PERSIST events for the EventJournal

Posted by "Julian Reschke (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Reschke resolved JCR-3172.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 2.4
    
> implement PERSIST events for the EventJournal
> ---------------------------------------------
>
>                 Key: JCR-3172
>                 URL: https://issues.apache.org/jira/browse/JCR-3172
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, observation
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: JCR-3172.diff
>
>
> See <http://www.day.com/specs/jcr/2.0/12_Observation.html#12.6.3%20Event%20Bundling%20in%20Journaled%20Observation>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (JCR-3172) implement PERSIST events for the EventJournal

Posted by "Julian Reschke (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Reschke reassigned JCR-3172:
-----------------------------------

    Assignee: Julian Reschke
    
> implement PERSIST events for the EventJournal
> ---------------------------------------------
>
>                 Key: JCR-3172
>                 URL: https://issues.apache.org/jira/browse/JCR-3172
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, observation
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>
> See <http://www.day.com/specs/jcr/2.0/12_Observation.html#12.6.3%20Event%20Bundling%20in%20Journaled%20Observation>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3172) implement PERSIST events for the EventJournal

Posted by "Stefan Guggisberg (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164400#comment-13164400 ] 

Stefan Guggisberg commented on JCR-3172:
----------------------------------------

we'll probably have to add a PERSIST event at the end of
o.a.jackrabbit.core.observation.EventStateCollection#createEventStates

                
> implement PERSIST events for the EventJournal
> ---------------------------------------------
>
>                 Key: JCR-3172
>                 URL: https://issues.apache.org/jira/browse/JCR-3172
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, observation
>            Reporter: Julian Reschke
>            Priority: Minor
>
> See <http://www.day.com/specs/jcr/2.0/12_Observation.html#12.6.3%20Event%20Bundling%20in%20Journaled%20Observation>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3172) implement PERSIST events for the EventJournal

Posted by "Julian Reschke (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Reschke updated JCR-3172:
--------------------------------

    Attachment:     (was: 3172.patch)
    
> implement PERSIST events for the EventJournal
> ---------------------------------------------
>
>                 Key: JCR-3172
>                 URL: https://issues.apache.org/jira/browse/JCR-3172
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, observation
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>         Attachments: JCR-3172.diff
>
>
> See <http://www.day.com/specs/jcr/2.0/12_Observation.html#12.6.3%20Event%20Bundling%20in%20Journaled%20Observation>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3172) implement PERSIST events for the EventJournal

Posted by "Julian Reschke (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Reschke updated JCR-3172:
--------------------------------

    Attachment: JCR-3172.diff

"final" patch. "final", as we apparently have zero test coverage, which I'll try to take care of next.
                
> implement PERSIST events for the EventJournal
> ---------------------------------------------
>
>                 Key: JCR-3172
>                 URL: https://issues.apache.org/jira/browse/JCR-3172
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, observation
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>         Attachments: JCR-3172.diff
>
>
> See <http://www.day.com/specs/jcr/2.0/12_Observation.html#12.6.3%20Event%20Bundling%20in%20Journaled%20Observation>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira