Re: [PR] [CELEBORN-2211] Avoid allocating additional buffers When HdfsFlushTask writes data [celeborn]

["RexXiong (via GitHub)" <gi...@apache.org>]

RexXiong commented on code in PR #3548:
URL: https://github.com/apache/celeborn/pull/3548#discussion_r2661708531


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriter.scala:
##########
@@ -580,7 +586,11 @@ class DfsTierWriter(
         case ex: InterruptedException =>
           throw new RuntimeException(ex)
       }
-      hadoopFs.create(dfsFileInfo.getDfsPath, true).close()
+      if (reuseHdfsOutputStreamEnabled) {
+        hdfsStream = hadoopFs.create(dfsFileInfo.getDfsPath, true)

Review Comment:
   It looks like previous hdfsStream could leak if an exception occurs. Is it properly closed/cleaned up in the exception path?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org