You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/07/14 04:27:05 UTC
[GitHub] [cordova-plugin-camera] erisu commented on a change in pull request #617: breaking(android): stop using CordovaUri helper class
erisu commented on a change in pull request #617:
URL: https://github.com/apache/cordova-plugin-camera/pull/617#discussion_r454091657
##########
File path: src/android/CameraLauncher.java
##########
@@ -290,10 +292,13 @@ public void takePicture(int returnType, int encodingType)
// Specify file so that large image is captured and returned
File photo = createCaptureFile(encodingType);
- this.imageUri = new CordovaUri(FileProvider.getUriForFile(cordova.getActivity(),
+ System.out.println("photo "+photo.getAbsolutePath());
Review comment:
Is this needed?
##########
File path: src/android/CameraLauncher.java
##########
@@ -290,10 +292,13 @@ public void takePicture(int returnType, int encodingType)
// Specify file so that large image is captured and returned
File photo = createCaptureFile(encodingType);
- this.imageUri = new CordovaUri(FileProvider.getUriForFile(cordova.getActivity(),
+ System.out.println("photo "+photo.getAbsolutePath());
+ this.imageFilePath = photo.getAbsolutePath();
+ this.imageUri = FileProvider.getUriForFile(cordova.getActivity(),
applicationId + ".provider",
- photo));
- intent.putExtra(MediaStore.EXTRA_OUTPUT, imageUri.getCorrectUri());
+ photo);
+ System.out.println("image uri "+this.imageUri);
Review comment:
Same
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org