You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/04/21 21:56:30 UTC

[GitHub] [commons-crypto] geoffreyblake opened a new pull request #98: Update pom.xml to explicitly prevent cleaning during release:prepare

geoffreyblake opened a new pull request #98:
URL: https://github.com/apache/commons-crypto/pull/98


   Update pom.xml to configure the maven-release-plugin to not perform and clean when doing a release:prepare to allow build artifacts from other platform builds to be incorporated into the final Jar for publishing to the maven artifact repositories.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-crypto] geoffreyblake commented on pull request #98: Update pom.xml to explicitly prevent cleaning during release:prepare

Posted by GitBox <gi...@apache.org>.
geoffreyblake commented on pull request #98:
URL: https://github.com/apache/commons-crypto/pull/98#issuecomment-625383003


   Any opinion on this PR? Or do we need something more sophisticated to publish and release the jar for multi-arch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-crypto] coveralls commented on issue #98: Update pom.xml to explicitly prevent cleaning during release:prepare

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #98:
URL: https://github.com/apache/commons-crypto/pull/98#issuecomment-617453609


   
   [![Coverage Status](https://coveralls.io/builds/30241357/badge)](https://coveralls.io/builds/30241357)
   
   Coverage increased (+8.8%) to 73.861% when pulling **b50c00e547ecb65982d0db46e807f40b25b05bef on geoffreyblake:update_pom** into **47b625c2bd13a101e3a7ca0c003dd78e28535a4a on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-crypto] geoffreyblake commented on a change in pull request #98: Update pom.xml to explicitly prevent cleaning during release:prepare

Posted by GitBox <gi...@apache.org>.
geoffreyblake commented on a change in pull request #98:
URL: https://github.com/apache/commons-crypto/pull/98#discussion_r413083593



##########
File path: pom.xml
##########
@@ -606,6 +606,14 @@ The following provides more details on the included cryptographic software:
           <ignoredDifferencesFile>${basedir}/clirr-excludes.xml</ignoredDifferencesFile>
         </configuration>
       </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-release-plugin</artifactId>
+	      <version>2.5.3</version>
+	      <configuration>
+          <preparationGoals>verify</preparationGoals>
+	      </configuration>

Review comment:
       My text editor for some reason is mixing tabs and spaces.  Should be fixed now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-crypto] geoffreyblake commented on pull request #98: Update pom.xml to explicitly prevent cleaning during release:prepare

Posted by GitBox <gi...@apache.org>.
geoffreyblake commented on pull request #98:
URL: https://github.com/apache/commons-crypto/pull/98#issuecomment-619035088


   Any comments on this?  If building by hand, this seems to be a way for making the combined jar.  I've come across another example: https://github.com/theopenlab/leveldbjni shows a way to build all the artifacts and then combine them, but it requires major surgery to the pom files.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-crypto] coveralls edited a comment on issue #98: Update pom.xml to explicitly prevent cleaning during release:prepare

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #98:
URL: https://github.com/apache/commons-crypto/pull/98#issuecomment-617453609


   
   [![Coverage Status](https://coveralls.io/builds/30262685/badge)](https://coveralls.io/builds/30262685)
   
   Coverage remained the same at 76.057% when pulling **1bdb34231da34e0ebda5d0b123fcbb69144dc4c0 on geoffreyblake:update_pom** into **24897862c41a504a6987a65727669268019f6f2f on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-crypto] vanzin commented on pull request #98: Update pom.xml to explicitly prevent cleaning during release:prepare

Posted by GitBox <gi...@apache.org>.
vanzin commented on pull request #98:
URL: https://github.com/apache/commons-crypto/pull/98#issuecomment-625575064


   Gary didn't comment, and I'm ok with it, so merging.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-crypto] vanzin commented on a change in pull request #98: Update pom.xml to explicitly prevent cleaning during release:prepare

Posted by GitBox <gi...@apache.org>.
vanzin commented on a change in pull request #98:
URL: https://github.com/apache/commons-crypto/pull/98#discussion_r412564077



##########
File path: pom.xml
##########
@@ -606,6 +606,14 @@ The following provides more details on the included cryptographic software:
           <ignoredDifferencesFile>${basedir}/clirr-excludes.xml</ignoredDifferencesFile>
         </configuration>
       </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-release-plugin</artifactId>
+	      <version>2.5.3</version>
+	      <configuration>
+          <preparationGoals>verify</preparationGoals>
+	      </configuration>

Review comment:
       Indentation is funky.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org