You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/01/09 05:39:20 UTC

[GitHub] shazron closed pull request #424: PodsJson.increment/decrement has a code error resulting in pods not being installed while specified

shazron closed pull request #424: PodsJson.increment/decrement has a code error resulting in pods not being installed while specified
URL: https://github.com/apache/cordova-ios/pull/424
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bin/templates/scripts/cordova/lib/PodsJson.js b/bin/templates/scripts/cordova/lib/PodsJson.js
index 047052739..f88d9481c 100644
--- a/bin/templates/scripts/cordova/lib/PodsJson.js
+++ b/bin/templates/scripts/cordova/lib/PodsJson.js
@@ -86,7 +86,7 @@ PodsJson.prototype.increment = function (name) {
     var val = this.get(name);
     if (val) {
         val.count++;
-        this.setJson(val);
+        this.setJson(name, val);
     }
 };
 
@@ -97,7 +97,7 @@ PodsJson.prototype.decrement = function (name) {
         if (val.count <= 0) {
             this.remove(name);
         } else {
-            this.setJson(val);
+            this.setJson(name, val);
         }
     }
 };


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org