You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/09/08 08:19:53 UTC
[GitHub] [nifi] noppomatsuda opened a new pull request #4515: NIFI-7728: FetchS3Object sends a flowfile to failure relationship if the given bucket or object key is empty
noppomatsuda opened a new pull request #4515:
URL: https://github.com/apache/nifi/pull/4515
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
https://issues.apache.org/jira/browse/NIFI-7728
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] kpsngh1998 commented on a change in pull request #4515: NIFI-7728: FetchS3Object sends a flowfile to failure relationship if the given bucket or object key is empty
Posted by GitBox <gi...@apache.org>.
kpsngh1998 commented on a change in pull request #4515:
URL: https://github.com/apache/nifi/pull/4515#discussion_r501449404
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java
##########
@@ -139,6 +140,13 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
final String versionId = context.getProperty(VERSION_ID).evaluateAttributeExpressions(flowFile).getValue();
final boolean requesterPays = context.getProperty(REQUESTER_PAYS).asBoolean();
+ if (StringUtils.isEmpty(bucket) || StringUtils.isEmpty(key)) {
Review comment:
If I understood correctly, you are solving the case when bucket/key are **""** or **sequence of whitespaces only** .
There are two things:
org.apache.nifi.util.StringUtils.isEmpty don't check for whitespaces. So instead of StringUtils.isEmpty you can use StringUtils.isBlank which also checks for whitespaces. Or you can add StandardValidators.NON_BLANK_VALIDATOR in both the properties validation which will show validation error for whitespaces/empty strings.
"Both 'Bucket' and 'Object Key' cannot be empty" This error message will be logged even if only one is empty other is not, which is somewhat misleading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] kpsngh1998 commented on a change in pull request #4515: NIFI-7728: FetchS3Object sends a flowfile to failure relationship if the given bucket or object key is empty
Posted by GitBox <gi...@apache.org>.
kpsngh1998 commented on a change in pull request #4515:
URL: https://github.com/apache/nifi/pull/4515#discussion_r501449404
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java
##########
@@ -139,6 +140,13 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
final String versionId = context.getProperty(VERSION_ID).evaluateAttributeExpressions(flowFile).getValue();
final boolean requesterPays = context.getProperty(REQUESTER_PAYS).asBoolean();
+ if (StringUtils.isEmpty(bucket) || StringUtils.isEmpty(key)) {
Review comment:
If I understood correctly, you are solving the case when bucket/key are **""** or **sequence of whitespaces only** .
There are two things:
- org.apache.nifi.util.StringUtils.isEmpty don't check for whitespaces. So instead of StringUtils.isEmpty you can use StringUtils.isBlank which also checks for whitespaces. Or you can add StandardValidators.NON_BLANK_VALIDATOR in both the properties validation which will show validation error for whitespaces/empty strings.
- "Both 'Bucket' and 'Object Key' cannot be empty" This error message will be logged even if only one is empty other is not, which is somewhat misleading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] kotarot commented on pull request #4515: NIFI-7728: FetchS3Object sends a flowfile to failure relationship if the given bucket or object key is empty
Posted by GitBox <gi...@apache.org>.
kotarot commented on pull request #4515:
URL: https://github.com/apache/nifi/pull/4515#issuecomment-705959732
Hi, Thank you for your reviews!
The original contributor of this PR has already left working this development, I will deal with it instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] kpsngh1998 commented on a change in pull request #4515: NIFI-7728: FetchS3Object sends a flowfile to failure relationship if the given bucket or object key is empty
Posted by GitBox <gi...@apache.org>.
kpsngh1998 commented on a change in pull request #4515:
URL: https://github.com/apache/nifi/pull/4515#discussion_r501449404
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java
##########
@@ -139,6 +140,13 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
final String versionId = context.getProperty(VERSION_ID).evaluateAttributeExpressions(flowFile).getValue();
final boolean requesterPays = context.getProperty(REQUESTER_PAYS).asBoolean();
+ if (StringUtils.isEmpty(bucket) || StringUtils.isEmpty(key)) {
Review comment:
If I understood correctly, you are solving the case when bucket/key are **""** or **<sequence of whitespaces only>** .
There are two things:
org.apache.nifi.util.StringUtils.isEmpty don't check for whitespaces. So instead of StringUtils.isEmpty you can use StringUtils.isBlank which also checks for whitespaces. Or you can add StandardValidators.NON_BLANK_VALIDATOR in both the properties validation which will show validation error for whitespaces/empty strings.
"Both 'Bucket' and 'Object Key' cannot be empty" This error message will be logged even if only one is empty other is not, which is somewhat misleading.
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java
##########
@@ -139,6 +140,13 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
final String versionId = context.getProperty(VERSION_ID).evaluateAttributeExpressions(flowFile).getValue();
final boolean requesterPays = context.getProperty(REQUESTER_PAYS).asBoolean();
+ if (StringUtils.isEmpty(bucket) || StringUtils.isEmpty(key)) {
Review comment:
If I understood correctly, you are solving the case when bucket/key are **""** or **sequence of whitespaces only** .
There are two things:
org.apache.nifi.util.StringUtils.isEmpty don't check for whitespaces. So instead of StringUtils.isEmpty you can use StringUtils.isBlank which also checks for whitespaces. Or you can add StandardValidators.NON_BLANK_VALIDATOR in both the properties validation which will show validation error for whitespaces/empty strings.
"Both 'Bucket' and 'Object Key' cannot be empty" This error message will be logged even if only one is empty other is not, which is somewhat misleading.
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java
##########
@@ -139,6 +140,13 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
final String versionId = context.getProperty(VERSION_ID).evaluateAttributeExpressions(flowFile).getValue();
final boolean requesterPays = context.getProperty(REQUESTER_PAYS).asBoolean();
+ if (StringUtils.isEmpty(bucket) || StringUtils.isEmpty(key)) {
Review comment:
If I understood correctly, you are solving the case when bucket/key are **""** or **sequence of whitespaces only** .
There are two things:
- org.apache.nifi.util.StringUtils.isEmpty don't check for whitespaces. So instead of StringUtils.isEmpty you can use StringUtils.isBlank which also checks for whitespaces. Or you can add StandardValidators.NON_BLANK_VALIDATOR in both the properties validation which will show validation error for whitespaces/empty strings.
- "Both 'Bucket' and 'Object Key' cannot be empty" This error message will be logged even if only one is empty other is not, which is somewhat misleading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #4515: NIFI-7728: FetchS3Object sends a flowfile to failure relationship if the given bucket or object key is empty
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #4515:
URL: https://github.com/apache/nifi/pull/4515#issuecomment-819929736
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] kotarot commented on a change in pull request #4515: NIFI-7728: FetchS3Object sends a flowfile to failure relationship if the given bucket or object key is empty
Posted by GitBox <gi...@apache.org>.
kotarot commented on a change in pull request #4515:
URL: https://github.com/apache/nifi/pull/4515#discussion_r502182250
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java
##########
@@ -139,6 +140,13 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
final String versionId = context.getProperty(VERSION_ID).evaluateAttributeExpressions(flowFile).getValue();
final boolean requesterPays = context.getProperty(REQUESTER_PAYS).asBoolean();
+ if (StringUtils.isEmpty(bucket) || StringUtils.isEmpty(key)) {
Review comment:
In my opinion, if we set 'bucket name' property to " " (a string with whitespaces only) or an expression language whose evaluated value is " ", the flowfile correctly goes to failure relationship with "The specified bucket does not exist" or "The specified key does not exist" errors already. So the checking for Empty here is enough, in my opinion.
Also, unfortunately, adding `StandardValidators.NON_BLANK_VALIDATOR` does not work because an empty string appears after evaluating an expression language. The expression language passes through this validator. Note that for these properties, `StandardValidators.NON_EMPTY_VALIDATOR` is already applied.
- Please see:
- https://github.com/apache/nifi/blob/a95ffce6bd451fc4a65bb1be9346a05fd42c0f41/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/s3/AbstractS3Processor.java#L111
- https://github.com/apache/nifi/blob/a95ffce6bd451fc4a65bb1be9346a05fd42c0f41/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/s3/AbstractS3Processor.java#L116
Regarding the error message, it makes sence, I'll fix it. Thank you for pointing it out!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] kpsngh1998 commented on a change in pull request #4515: NIFI-7728: FetchS3Object sends a flowfile to failure relationship if the given bucket or object key is empty
Posted by GitBox <gi...@apache.org>.
kpsngh1998 commented on a change in pull request #4515:
URL: https://github.com/apache/nifi/pull/4515#discussion_r501449404
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java
##########
@@ -139,6 +140,13 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
final String versionId = context.getProperty(VERSION_ID).evaluateAttributeExpressions(flowFile).getValue();
final boolean requesterPays = context.getProperty(REQUESTER_PAYS).asBoolean();
+ if (StringUtils.isEmpty(bucket) || StringUtils.isEmpty(key)) {
Review comment:
If I understood correctly, you are solving the case when bucket/key are **""** or **<sequence of whitespaces only>** .
There are two things:
org.apache.nifi.util.StringUtils.isEmpty don't check for whitespaces. So instead of StringUtils.isEmpty you can use StringUtils.isBlank which also checks for whitespaces. Or you can add StandardValidators.NON_BLANK_VALIDATOR in both the properties validation which will show validation error for whitespaces/empty strings.
"Both 'Bucket' and 'Object Key' cannot be empty" This error message will be logged even if only one is empty other is not, which is somewhat misleading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] kotarot commented on pull request #4515: NIFI-7728: FetchS3Object sends a flowfile to failure relationship if the given bucket or object key is empty
Posted by GitBox <gi...@apache.org>.
kotarot commented on pull request #4515:
URL: https://github.com/apache/nifi/pull/4515#issuecomment-705959732
Hi, Thank you for your reviews!
The original contributor of this PR has already left working this development, I will deal with it instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] kotarot commented on a change in pull request #4515: NIFI-7728: FetchS3Object sends a flowfile to failure relationship if the given bucket or object key is empty
Posted by GitBox <gi...@apache.org>.
kotarot commented on a change in pull request #4515:
URL: https://github.com/apache/nifi/pull/4515#discussion_r502182250
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java
##########
@@ -139,6 +140,13 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
final String versionId = context.getProperty(VERSION_ID).evaluateAttributeExpressions(flowFile).getValue();
final boolean requesterPays = context.getProperty(REQUESTER_PAYS).asBoolean();
+ if (StringUtils.isEmpty(bucket) || StringUtils.isEmpty(key)) {
Review comment:
In my opinion, if we set 'bucket name' property to " " (a string with whitespaces only) or an expression language whose evaluated value is " ", the flowfile correctly goes to failure relationship with "The specified bucket does not exist" or "The specified key does not exist" errors already. So the checking for Empty here is enough, in my opinion.
Also, unfortunately, adding `StandardValidators.NON_BLANK_VALIDATOR` does not work because an empty string appears after evaluating an expression language. The expression language passes through this validator. Note that for these properties, `StandardValidators.NON_EMPTY_VALIDATOR` is already applied.
- Please see:
- https://github.com/apache/nifi/blob/a95ffce6bd451fc4a65bb1be9346a05fd42c0f41/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/s3/AbstractS3Processor.java#L111
- https://github.com/apache/nifi/blob/a95ffce6bd451fc4a65bb1be9346a05fd42c0f41/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/s3/AbstractS3Processor.java#L116
Regarding the error message, it makes sence, I'll fix it. Thank you for pointing it out!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] closed pull request #4515: NIFI-7728: FetchS3Object sends a flowfile to failure relationship if the given bucket or object key is empty
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #4515:
URL: https://github.com/apache/nifi/pull/4515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org