You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/03 18:54:53 UTC
[GitHub] [arrow] coryan opened a new pull request #11851: ARROW-14506: [C++] Conda support for google-cloud-cpp
coryan opened a new pull request #11851:
URL: https://github.com/apache/arrow/pull/11851
This PR adds support for `google-cloud-cpp` to the Conda files.
Probably the most difficult change to grok is the change to compile with
C++17 when using Conda:
- Conda defaults all its builds to C++17,
[this bug](https://github.com/conda/conda-build/issues/3375) goes into
some detail as to why.
- Arrow defaults to C++11 if no `CMAKE_CXX_STANDARD` argument is
provided.
- Abseil's ABI changes when used from C++11 vs. C++17, see
https://github.com/abseil/abseil-cpp/issues/696
- Therefore, one must compile with C++17 to use Abseil in Conda.
- And because `google-cloud-cpp` has a direct dependency on Abseil,
exposed through the headers, one must use C++17 to use
`google-cloud-cpp` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] coryan closed pull request #11851: ARROW-14506: [C++] Conda support for google-cloud-cpp
Posted by GitBox <gi...@apache.org>.
coryan closed pull request #11851:
URL: https://github.com/apache/arrow/pull/11851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #11851: ARROW-14506: [C++] Conda support for google-cloud-cpp
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #11851:
URL: https://github.com/apache/arrow/pull/11851#discussion_r763066539
##########
File path: ci/conda_env_cpp_linux.txt
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+google-cloud-cpp>=1.34.0
Review comment:
Is `google-cloud-cpp` only supported on linux?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11851: ARROW-14506: [C++] Conda support for google-cloud-cpp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11851:
URL: https://github.com/apache/arrow/pull/11851#issuecomment-985752756
https://issues.apache.org/jira/browse/ARROW-14506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] coryan commented on a change in pull request #11851: ARROW-14506: [C++] Conda support for google-cloud-cpp
Posted by GitBox <gi...@apache.org>.
coryan commented on a change in pull request #11851:
URL: https://github.com/apache/arrow/pull/11851#discussion_r763076262
##########
File path: dev/tasks/conda-recipes/arrow-cpp/build-arrow.sh
##########
@@ -58,6 +58,7 @@ cmake \
-DARROW_DEPENDENCY_SOURCE=SYSTEM \
-DARROW_FLIGHT=ON \
-DARROW_FLIGHT_REQUIRE_TLSCREDENTIALSOPTIONS=ON \
+ -DARROW_GCS=ON \
-DARROW_HDFS=ON \
Review comment:
Done. I suspect this may break things (see below).
##########
File path: ci/conda_env_cpp_linux.txt
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+google-cloud-cpp>=1.34.0
Review comment:
`google-cloud-cpp` is supported on Linux, Windows and macOS. The Conda packages only work on Linux and macOS:
https://github.com/conda-forge/google-cloud-cpp-feedstock/issues/76
If needed, I am happy to fix the Conda package first and then resubmit this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #11851: ARROW-14506: [C++] Conda support for google-cloud-cpp
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #11851:
URL: https://github.com/apache/arrow/pull/11851#discussion_r763065872
##########
File path: dev/tasks/conda-recipes/arrow-cpp/build-arrow.sh
##########
@@ -58,6 +58,7 @@ cmake \
-DARROW_DEPENDENCY_SOURCE=SYSTEM \
-DARROW_FLIGHT=ON \
-DARROW_FLIGHT_REQUIRE_TLSCREDENTIALSOPTIONS=ON \
+ -DARROW_GCS=ON \
-DARROW_HDFS=ON \
Review comment:
The meta.yml must also contain the `google-cloud-cpp` host dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #11851: ARROW-14506: [C++] Conda support for google-cloud-cpp
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #11851:
URL: https://github.com/apache/arrow/pull/11851#discussion_r763085539
##########
File path: ci/conda_env_cpp_linux.txt
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+google-cloud-cpp>=1.34.0
Review comment:
That would certainly simplify this PR. Until that we can use the bundled google-cloud-cpp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] coryan commented on pull request #11851: ARROW-14506: [C++] Conda support for google-cloud-cpp
Posted by GitBox <gi...@apache.org>.
coryan commented on pull request #11851:
URL: https://github.com/apache/arrow/pull/11851#issuecomment-986859140
Closing until the Conda packages are fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org