You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/25 17:02:38 UTC

[GitHub] [arrow] boshek opened a new issue, #14734: Deprecated filter + across usage

boshek opened a new issue, #14734:
URL: https://github.com/apache/arrow/issues/14734

   ### Describe the bug, including details regarding any error messages, version, and platform.
   
   :wave: the addition of `across` and family of functions has been such a powerful addition to the arrow R package. Thank you!
   
   Recently in dplyr [itself](https://github.com/tidyverse/dplyr/pull/6468) `filter` + `across` was deprecated. dplyr now throws a warning when trying to do that:
   
   ``` r
   library(dplyr)
   
   starwars %>%
     filter(across(height, ~ .x >= 100))
   #> Warning: Using `across()` in `filter()` is deprecated, use `if_any()` or
   #> `if_all()`.
   ```
   
   This is done here in dplyr:
   
   https://github.com/tidyverse/dplyr/blob/4d0ac622c0e33c758b05a1582766fcd438cb79c1/R/filter.R#L269-L277
   
   Right now arrow does not warn:
   
   ```r
   library(dplyr)
   library(arrow)
   
   starwars %>%
     arrow_table() %>%
     filter(across(height, ~ .x >= 100)) %>%
     collect()
   ```
   
   Though arrow doesn't have the same deprecation plumbing set up my initial thought is that we could add something in here to catch instances when `filter` + `across` are used:
   
   https://github.com/apache/arrow/blob/2078af7c710d688c14313b9486b99c981550a7b7/r/R/dplyr-across.R#L26-L72
   
   
   ### Component(s)
   
   R


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] thisisnic commented on issue #14734: Deprecated filter + across usage

Posted by GitBox <gi...@apache.org>.
thisisnic commented on issue #14734:
URL: https://github.com/apache/arrow/issues/14734#issuecomment-1327719706

   Thanks for reporting this, I agree we should add a deprecation message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org