[jira] [Comment Edited] (CASSANDRA-14870) The order of application of nodetool garbagecollect is broken

["Branimir Lambov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-14870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678154#comment-16678154 ] 

Branimir Lambov edited comment on CASSANDRA-14870 at 11/7/18 12:44 PM:
-----------------------------------------------------------------------

Patch for 3.11 linked, applies with insignificant changes to trunk too. Incorporates CASSANDRA-14099 as that required the same change of order.
The LCS ordering test (by [~VincentWhite]) is copied from the CASSANDRA-14099 patch.


was (Author: blambov):
Patch for 3.11 linked, applies with insignificant changes to master too. Incorporates CASSANDRA-14099 as that required the same change of order.
The LCS ordering test (by [~VincentWhite]) is copied from the CASSANDRA-14099 patch.

> The order of application of nodetool garbagecollect is broken
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-14870
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14870
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Branimir Lambov
>            Assignee: Branimir Lambov
>            Priority: Major
>
> {{nodetool garbagecollect}} was intended to work from oldest sstable to newest, so that the collection in newer tables can purge tombstones over data that has been deleted.
> However, {{SSTableReader.maxTimestampComparator}} currently sorts in the opposite order (the order changed in CASSANDRA-13776 and then back in CASSANDRA-14010), which makes the garbage collection unable to purge any tombstones.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org