You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sdarlington (via GitHub)" <gi...@apache.org> on 2023/06/30 16:31:17 UTC
[GitHub] [ignite-extensions] sdarlington opened a new pull request, #220: IGNITE-19899 Use autoconfigure scheme for SpringBoot 2.7+
sdarlington opened a new pull request, #220:
URL: https://github.com/apache/ignite-extensions/pull/220
SpringBoot 2.7 uses a different way of finding extensions. This leaves the old method intact but allows the autoconfigurer to work with versions 2.7 and 3.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-extensions] sdarlington commented on pull request #220: IGNITE-19899 Use autoconfigure scheme for SpringBoot 2.7+
Posted by "sdarlington (via GitHub)" <gi...@apache.org>.
sdarlington commented on PR #220:
URL: https://github.com/apache/ignite-extensions/pull/220#issuecomment-1620291411
Tests passed:
Thin client: https://ci.ignite.apache.org/buildConfiguration/IgniteExtensions_Tests_SpringBootThinClientAutoconfigure/7341174?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true
Thick client: https://ci.ignite.apache.org/buildConfiguration/IgniteExtensions_Tests_SpringBootAutoconfigure/7341176?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-19899 Use autoconfigure scheme for SpringBoot 2.7+ [ignite-extensions]
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 merged PR #220:
URL: https://github.com/apache/ignite-extensions/pull/220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-extensions] SammyVimes commented on a diff in pull request #220: IGNITE-19899 Use autoconfigure scheme for SpringBoot 2.7+
Posted by "SammyVimes (via GitHub)" <gi...@apache.org>.
SammyVimes commented on code in PR #220:
URL: https://github.com/apache/ignite-extensions/pull/220#discussion_r1265071828
##########
modules/spring-boot-thin-client-autoconfigure-ext/spring-boot-thin-client-autoconfigure/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports:
##########
@@ -0,0 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.ignite.springframework.boot.autoconfigure.IgniteClientAutoConfiguration
+org.apache.ignite.springframework.boot.autoconfigure.IgniteClientRepositoryAutoConfiguration
Review Comment:
Missing new line in the end of file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org