You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "yamt (via GitHub)" <gi...@apache.org> on 2024/01/04 09:24:03 UTC
[PR] libcxx.defs: appease "expr: syntax error" messages with clang [nuttx]
yamt opened a new pull request, #11474:
URL: https://github.com/apache/nuttx/pull/11474
## Summary
libcxx.defs: appease "expr: syntax error" messages with clang
## Impact
## Testing
sim/macOS (with a lot of other local patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] libcxx.defs: appease "expr: syntax error" messages with clang [nuttx]
Posted by "jerpelea (via GitHub)" <gi...@apache.org>.
jerpelea commented on PR #11474:
URL: https://github.com/apache/nuttx/pull/11474#issuecomment-1876887730
> > please add a commit message and sign your commit
>
> signed-off-by is a linux thing, not ours, as far as i know.
does not look signed
please use
git commit -sm"message to be added
body for the message "
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] libcxx.defs: appease "expr: syntax error" messages with clang [nuttx]
Posted by "jerpelea (via GitHub)" <gi...@apache.org>.
jerpelea commented on PR #11474:
URL: https://github.com/apache/nuttx/pull/11474#issuecomment-1876956490
> > > > please add a commit message and sign your commit
> > >
> > >
> > > signed-off-by is a linux thing, not ours, as far as i know.
> >
> >
> > does not look signed please use
> > git commit -sm"message to be added
> > body for the message "
>
> have we mandated to use -s? why? do we have DCO-style doc?
>
> i don't see why you request multi-line commit messages for super simple patches like this.
-s adds signature to your patch
a commit message should have a title and a body
nothing is enforced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] libcxx.defs: appease "expr: syntax error" messages with clang [nuttx]
Posted by "yamt (via GitHub)" <gi...@apache.org>.
yamt commented on PR #11474:
URL: https://github.com/apache/nuttx/pull/11474#issuecomment-1876884719
> please add a commit message and sign your commit
signed-off-by is a linux thing, not ours, as far as i know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] libcxx.defs: appease "expr: syntax error" messages with clang [nuttx]
Posted by "jerpelea (via GitHub)" <gi...@apache.org>.
jerpelea merged PR #11474:
URL: https://github.com/apache/nuttx/pull/11474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] libcxx.defs: appease "expr: syntax error" messages with clang [nuttx]
Posted by "yamt (via GitHub)" <gi...@apache.org>.
yamt commented on PR #11474:
URL: https://github.com/apache/nuttx/pull/11474#issuecomment-1876976696
> > > > > please add a commit message and sign your commit
> > > >
> > > >
> > > > signed-off-by is a linux thing, not ours, as far as i know.
> > >
> > >
> > > does not look signed please use
> > > git commit -sm"message to be added
> > > body for the message "
> >
> >
> > have we mandated to use -s? why? do we have DCO-style doc?
> > i don't see why you request multi-line commit messages for super simple patches like this.
>
> -s adds signature to your patch and signig your patches is a good practice not a linux thing a commit
without project's definition of it, signed-off-by is meaningless, as far as i understand.
linux has its definition somewhere under their Documenatation.
if you want to make us follow it, i don't necessarily object.
> message should have a title and a body no matter if it is a small or huge patch
i agree small/huge doesn't matter.
what actually matters is simple/complex.
>
> nothing is enforced, it as just a wish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] libcxx.defs: appease "expr: syntax error" messages with clang [nuttx]
Posted by "yamt (via GitHub)" <gi...@apache.org>.
yamt commented on PR #11474:
URL: https://github.com/apache/nuttx/pull/11474#issuecomment-1876953395
> > > please add a commit message and sign your commit
> >
> >
> > signed-off-by is a linux thing, not ours, as far as i know.
>
> does not look signed please use
>
> git commit -sm"message to be added
>
> body for the message "
have we mandated to use -s? why? do we have DCO-style doc?
i don't see why you request multi-line commit messages for super simple patches like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org