[GitHub] [spark] hayssams commented on pull request #42545: [SPARK-44866][SQL] Add `SnowflakeDialect` to handle BOOLEAN type correctly

["hayssams (via GitHub)" <gi...@apache.org>]

hayssams commented on PR #42545:
URL: https://github.com/apache/spark/pull/42545#issuecomment-1712227611

   Hi @dongjoon
   Yes we are using this PR without any other issue.
   On the other hand before submitting this PR, I looked at the default JDBC
   mapping and did not find any other incompatibility
   
   
   On Fri 8 Sep 2023 at 22:51 Dongjoon Hyun ***@***.***> wrote:
   
   > ***@***.**** commented on this pull request.
   >
   > Thank you for making a PR, @hayssams <https://github.com/hayssams> .
   >
   > Since this PR adds a new dialect, I need to ask if you are using this code
   > without any other issues.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/spark/pull/42545#pullrequestreview-1618252630>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAS4ACE34FTZ3OUURND777DXZOAOXANCNFSM6AAAAAA3USZKMY>
   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org