You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nixon Rodrigues <ni...@freestoneinfotech.com> on 2018/06/21 07:18:36 UTC

Review Request 67682: ATLAS-2762: Update AtlasRelatedObjectId with addition of entityStatus attribute

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67682/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-2762
    https://issues.apache.org/jira/browse/ATLAS-2762


Repository: atlas


Description
-------

Problem: In relationshipAttributes we don't have entity status and for showing entity status we need to make separate ajax call to read only one property i.e entity status.

Adding entityStatus would simplify in UI relationship node rendering.


Diffs
-----

  intg/src/main/java/org/apache/atlas/model/instance/AtlasRelatedObjectId.java 543de61dc 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java cea63f02d 


Diff: https://reviews.apache.org/r/67682/diff/1/


Testing
-------

entityStatus attribute is rightly renderend in relationshipAttributes json.


https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/482/console


Thanks,

Nixon Rodrigues


Re: Review Request 67682: ATLAS-2762: Update AtlasRelatedObjectId with addition of entityStatus attribute

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67682/#review205154
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On June 21, 2018, 7:18 a.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67682/
> -----------------------------------------------------------
> 
> (Updated June 21, 2018, 7:18 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2762
>     https://issues.apache.org/jira/browse/ATLAS-2762
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Problem: In relationshipAttributes we don't have entity status and for showing entity status we need to make separate ajax call to read only one property i.e entity status.
> 
> Adding entityStatus would simplify in UI relationship node rendering.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelatedObjectId.java 543de61dc 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java cea63f02d 
> 
> 
> Diff: https://reviews.apache.org/r/67682/diff/1/
> 
> 
> Testing
> -------
> 
> entityStatus attribute is rightly renderend in relationshipAttributes json.
> 
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/482/console
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>


Re: Review Request 67682: ATLAS-2762: Update AtlasRelatedObjectId with addition of entityStatus attribute

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67682/
-----------------------------------------------------------

(Updated June 21, 2018, 1:18 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.


Changes
-------

This patch includes UI changes to render entity status attribute for entities on relationship tab. 
And the edge status with relationshipStatus attribute.


Bugs: ATLAS-2762
    https://issues.apache.org/jira/browse/ATLAS-2762


Repository: atlas


Description
-------

Problem: In relationshipAttributes we don't have entity status and for showing entity status we need to make separate ajax call to read only one property i.e entity status.

Adding entityStatus would simplify in UI relationship node rendering.


Diffs (updated)
-----

  dashboardv2/public/js/utils/CommonViewFunction.js 241b812 
  dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js 0d66235 
  dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js 138e2cc 
  dashboardv2/public/js/views/graph/RelationshipLayoutView.js edb7672 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasRelatedObjectId.java 543de61 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java cea63f0 


Diff: https://reviews.apache.org/r/67682/diff/2/

Changes: https://reviews.apache.org/r/67682/diff/1-2/


Testing
-------

entityStatus attribute is rightly renderend in relationshipAttributes json.


https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/482/console


Thanks,

Nixon Rodrigues