JIRA question

[Rich Taylor <bh...@gmail.com>]

Was working on small change to add some consistency to logging output and
noticed a separate issue.   The logging changes are so small that I hate to
create a JIRA issue unnecessarily.  Would someone mind taking a look at the
attached diff file and letting me know if the issues are worth two separate
issues?   I'll be able to use the answer as a future guide.

First issue:
Wanted to add consistency to the logging messages when deploying a new
process
1. When deploying, the term "Activated" is used.  However when undeploying,
the term "Unregistered" is used.
2. When deploying a new process, the log says "Process foo-1 has been
unregistered", even if a no previous versions of foo were deployed.  This
was due to accidentally putting the log call outside of a conditional


Second Issue:
I haven't seen any direct affects from this code, but it is a bit off.  "p"
is never assigned a value before being referenced.  From BpelServerImpl.java
:
------------------------------------
BpelProcess p = null;
if (_engine != null) {
    _engine.unregisterProcess(pid);
    _registeredProcesses.remove(p);
}

Seems it should be something like this:
------------------------------------
BpelProcess p = null;
if (_engine != null) {
   p = _engine.unregisterProcess(pid);
   if (p != null)
   {
        _registeredProcesses.remove(p);
   }
}


Thanks! Rich

Re: JIRA question

[Matthieu Riou <ma...@offthelip.org>]

On 10/24/07, Rich Taylor <bh...@gmail.com> wrote:
>
> Was working on small change to add some consistency to logging output and
> noticed a separate issue.   The logging changes are so small that I hate to
> create a JIRA issue unnecessarily.  Would someone mind taking a look at the
> attached diff file and letting me know if the issues are worth two separate
> issues?   I'll be able to use the answer as a future guide.
>
> First issue:
> Wanted to add consistency to the logging messages when deploying a new
> process
> 1. When deploying, the term "Activated" is used.  However when
> undeploying, the term "Unregistered" is used.
> 2. When deploying a new process, the log says "Process foo-1 has been
> unregistered", even if a no previous versions of foo were deployed.  This
> was due to accidentally putting the log call outside of a conditional
>
>
> Second Issue:
> I haven't seen any direct affects from this code, but it is a bit off.
> "p" is never assigned a value before being referenced.  From
> BpelServerImpl.java:
> ------------------------------------
> BpelProcess p = null;
> if (_engine != null) {
>     _engine.unregisterProcess(pid);
>     _registeredProcesses.remove(p);
> }
>
> Seems it should be something like this:
> ------------------------------------
> BpelProcess p = null;
> if (_engine != null) {
>    p = _engine.unregisterProcess(pid);
>    if (p != null)
>    {
>         _registeredProcesses.remove(p);
>    }
> }


For that sort of almost cosmetic problem, a single Jira issue is okay as
it's below the threshold of things we want to track. Although you still need
to create at least one issue as you have to check that little "Grant license
to ASF" checkbox.

Cheers,
Matthieu

Thanks! Rich
>
>