You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Krishna Sadasivam <ks...@brocade.com> on 2012/08/14 23:27:49 UTC
Review Request: Brocade Plugin: Patch to use Base64 class from
org.apache.commons.codec.binary.Base64
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6614/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Patch to use Base64 class from org.apache.commons.codec.binary.Base64
Diffs
-----
plugins/network-elements/brocade/test/com/cloud/network/element/BrocadePluginTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/6614/diff/
Testing
-------
Unit test
Thanks,
Krishna Sadasivam
Re: Review Request: Brocade Plugin: Patch to use Base64 class from
org.apache.commons.codec.binary.Base64
Posted by Alex Huang <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6614/#review10863
-----------------------------------------------------------
I might be in the wrong here but none of the test methods seem to be verifying the operation worked or not.
- Alex Huang
On Aug. 14, 2012, 9:27 p.m., Krishna Sadasivam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6614/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2012, 9:27 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Patch to use Base64 class from org.apache.commons.codec.binary.Base64
>
>
> Diffs
> -----
>
> plugins/network-elements/brocade/test/com/cloud/network/element/BrocadePluginTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/6614/diff/
>
>
> Testing
> -------
>
> Unit test
>
>
> Thanks,
>
> Krishna Sadasivam
>
>
Re: Review Request: Brocade Plugin: Patch to use Base64 class from
org.apache.commons.codec.binary.Base64
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6614/#review15167
-----------------------------------------------------------
Any update on this?
- Rohit Yadav
On Aug. 14, 2012, 9:27 p.m., Krishna Sadasivam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6614/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2012, 9:27 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Patch to use Base64 class from org.apache.commons.codec.binary.Base64
>
>
> Diffs
> -----
>
> plugins/network-elements/brocade/test/com/cloud/network/element/BrocadePluginTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/6614/diff/
>
>
> Testing
> -------
>
> Unit test
>
>
> Thanks,
>
> Krishna Sadasivam
>
>