[GitHub] [druid] adarshsanjeev commented on a diff in pull request #13909: Add segment generator counters to MSQ reports

["adarshsanjeev (via GitHub)" <gi...@apache.org>]

adarshsanjeev commented on code in PR #13909:
URL: https://github.com/apache/druid/pull/13909#discussion_r1131296561


##########
docs/multi-stage-query/api.md:
##########
@@ -528,6 +530,10 @@ The response shows an example report for a query.
               "frames": [
                 73
               ]
+            },
+            "segmentGenerationProgress": {
+              "type": "segmentGenerationProgress",

Review Comment:
   Yes, I think it would cause a problem since we already use that name. I think ideally we should keep the names unique, to avoid any exceptions, since we cast to the child class after fetching based on channel name. 
   If we want "output" in the name to make it clear, we could rename this to "segmentGenerationOutput"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org