You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org> on 2007/02/02 13:07:05 UTC
[jira] Commented: (TAPESTRY-988) Function mismatch with description
in document: Form.jwc and tapestry.request.xml
[ https://issues.apache.org/jira/browse/TAPESTRY-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469729 ]
Andreas Andreou commented on TAPESTRY-988:
------------------------------------------
Regarding org.apache.tapestry.default-cookie-max-age, I guess it needs to be specified as a JVM system property.
Since CookieSource allows setting per-cookie max ages, i don't feel this is important any more - but the docs should be updated.
> Function mismatch with description in document: Form.jwc and tapestry.request.xml
> ----------------------------------------------------------------------------------
>
> Key: TAPESTRY-988
> URL: https://issues.apache.org/jira/browse/TAPESTRY-988
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.0.1
> Environment: hivemind1.1.1
> Reporter: sorphi
> Assigned To: Andreas Andreou
> Priority: Minor
> Fix For: 4.1.2
>
>
> 1/ Form component specifiaction
> <parameter name="clientValidationEnabled">
> <description>
> If true (the default) then client-side validation will be generated upon render for any
> required or validating fields.
> </description>
> </parameter>
> Shoud declare a default value as description elment said. Or else, the value of clientValidationEnabled property in enhanced Form class will be false.
> <parameter name="clientValidationEnabled" default-value="ognl:true">
> 2/CookieSource hivemind configuration:
> <service-point id="CookieSource">
>
> Allows access to incoming HTTP cookie values for the active (per-thread) request.
>
> <invoke-factory>
> <construct class="impl.CookieSourceImpl">
> <set-service property="request" service-id="tapestry.globals.HttpServletRequest"/>
> <set-service property="response" service-id="tapestry.globals.HttpServletResponse"/>
> <set property="defaultMaxAge" value="${org.apache.tapestry.default-cookie-max-age}"/>
> </construct>
> </invoke-factory>
> </service-point>
> <set property="defaultMaxAge" value="${org.apache.tapestry.default-cookie-max-age}"/>
> Here, defaultMaxAge value is injected by propertyname placeHolder, it will not prefer to search value from application specification meta elment - "org.apache.tapestry.default-cookie-max-age". (I test it twice.)
> But this document say that specialize meta in app spec will be useful. Or I misunderstand?
> http://jakarta.apache.org/tapestry/UsersGuide/configuration.html#configuration.properties
> I think "app-property:org.apache.tapestry.default-cookie-max-age" will be ok. Like this:
> <implementation service-id="tapestry.request.CookieSource">
> <invoke-factory>
> <construct class="framework.tapestry.service.CookieSourceImpl">
> <set-service property="request" service-id="tapestry.globals.HttpServletRequest"/>
> <set-service property="response" service-id="tapestry.globals.HttpServletResponse"/>
> <set-object property="defaultMaxAge" value="app-property:org.apache.tapestry.default-cookie-max-age"/>
> <set-object property="domain" value="app-property:framework.tapestry.default-cookie-domain"/>
> <set-object property="path" value="app-property:framework.tapestry.default-cookie-path"/>
> <set-object property="version" value="app-property:framework.tapestry.default-cookie-version"/>
> </construct>
> </invoke-factory>
> </implementation>
> But must define my own implements.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org