You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2021/02/09 05:51:15 UTC

Review Request 73178: RANGER-3175: Adding back support to retrieve users using group member attribute from AD/LDAP

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73178/
-----------------------------------------------------------

Review request for ranger, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.


Bugs: RANGER-3175
    https://issues.apache.org/jira/browse/RANGER-3175


Repository: ranger


Description
-------

Added code to retrieve users from group member attribute when usersearch is disabled. Also handled upgrade dependency from older version where usersearch option was available only when group search first is enabled.


Diffs
-----

  ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java c8fe3fcf9 
  ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java 31e15a139 


Diff: https://reviews.apache.org/r/73178/diff/1/


Testing
-------

1. Patched cluster with the changes and verified the functionality with nested groups as well as role assignments.
2. Also verified functionality for regressions.


Thanks,

Sailaja Polavarapu


Re: Review Request 73178: RANGER-3175: Adding back support to retrieve users using group member attribute from AD/LDAP

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73178/#review222585
-----------------------------------------------------------


Ship it!




Ship It!

- Abhay Kulkarni


On Feb. 11, 2021, 12:04 a.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73178/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2021, 12:04 a.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3175
>     https://issues.apache.org/jira/browse/RANGER-3175
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Added code to retrieve users from group member attribute when usersearch is disabled. Also handled upgrade dependency from older version where usersearch option was available only when group search first is enabled.
> 
> 
> Diffs
> -----
> 
>   ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java c8fe3fcf9 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java 31e15a139 
> 
> 
> Diff: https://reviews.apache.org/r/73178/diff/2/
> 
> 
> Testing
> -------
> 
> 1. Patched cluster with the changes and verified the functionality with nested groups as well as role assignments.
> 2. Also verified functionality for regressions.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>


Re: Review Request 73178: RANGER-3175: Adding back support to retrieve users using group member attribute from AD/LDAP

Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73178/
-----------------------------------------------------------

(Updated Feb. 11, 2021, 12:04 a.m.)


Review request for ranger, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.


Changes
-------

Based on the review simplified the condition for updating userSearchEnabled flag.


Bugs: RANGER-3175
    https://issues.apache.org/jira/browse/RANGER-3175


Repository: ranger


Description
-------

Added code to retrieve users from group member attribute when usersearch is disabled. Also handled upgrade dependency from older version where usersearch option was available only when group search first is enabled.


Diffs (updated)
-----

  ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java c8fe3fcf9 
  ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java 31e15a139 


Diff: https://reviews.apache.org/r/73178/diff/2/

Changes: https://reviews.apache.org/r/73178/diff/1-2/


Testing
-------

1. Patched cluster with the changes and verified the functionality with nested groups as well as role assignments.
2. Also verified functionality for regressions.


Thanks,

Sailaja Polavarapu