You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/16 20:06:12 UTC

[GitHub] [incubator-superset] villebro opened a new pull request #8058: [WIP] Add typing to db_engine_specs

villebro opened a new pull request #8058: [WIP] Add typing to db_engine_specs
URL: https://github.com/apache/incubator-superset/pull/8058
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [x] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Before starting work to remove circular imports from `db_engine_specs`, this PR aims to add typing to most methods in `db_engine_specs`. 
   
   ### TEST PLAN
   Mypy (CI)
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org