You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by prasadwagle <gi...@git.apache.org> on 2016/12/20 05:38:49 UTC

[GitHub] zeppelin pull request #1785: [ZEPPELIN-1833] Fix bug in ClientFactory.destro...

GitHub user prasadwagle opened a pull request:

    https://github.com/apache/zeppelin/pull/1785

    [ZEPPELIN-1833] Fix bug in ClientFactory.destroyObject that does not close socket connections

    ### What is this PR for?
    Fix bug in ClientFactory.destroyObject that does not close socket connections
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    NA
    
    ### What is the Jira issue?
    [ZEPPELIN-1833](https://issues.apache.org/jira/browse/ZEPPELIN-1833)
    
    ### How should this be tested?
    * Create multiple paragraphs and execute them in parallel. This will create multiple thrift clients and active connections.
    * When the clients are returned to the object pool, verify that the destroyObject correctly closes connections. Use the netstat command to get number of active connections.
    
    ### Screenshots (if appropriate)
    NA
    
    ### Questions:
    * Does the licenses files need update?
    No
    * Is there breaking changes for older versions?
    No
    * Does this needs documentation?
    No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prasadwagle/incubator-zeppelin ZEPPELIN-1833

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1785.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1785
    
----
commit 3e5ccd73bac06c84295cc30f31e9421ef0dc4dfb
Author: Prasad Wagle <pw...@twitter.com>
Date:   2016-12-20T05:02:18Z

    Use correct client hashmap key to close socket

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1785: [ZEPPELIN-1833] Fix bug in ClientFactory.destro...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1785


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1785: [ZEPPELIN-1833] Fix bug in ClientFactory.destroyObject...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1785
  
    LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1785: [ZEPPELIN-1833] Fix bug in ClientFactory.destroyObject...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1785
  
    LGTM and merge to master if there no further comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1785: [ZEPPELIN-1833] Fix bug in ClientFactory.destroyObject...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/1785
  
    Thanks @prasadwagle. Lgtm. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---