You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@lyra.org> on 2003/09/24 18:20:22 UTC
retry_txn (was: svn commit: rev 7096 - in trunk/subversion: libsvn_fs tests/libsvn_fs)
[ dang. deleted the original commit mail ]
On Fri, Sep 19, 2003 at 03:31:46PM -0700, Greg Stein wrote:
> On Fri, Sep 19, 2003 at 11:45:04AM -0500, cmpilato@tigris.org wrote:
> >...
> > Log:
> > Here we go. A first step towards solving issue #1499 (the oh-my-gosh-
> > our-bdb-transaction-usage-is-horrible bug).
I think this pattern is incorrect. Rather than having one function which
operates in two *entirely* different modes based on a rather nondescript 0
or 1 passed to it, it would have been better to have two function names.
Keep _retry_txn for dbtxn-based operations. Use _retry for plain ops.
Under the covers, you might factor it with a txn, or maybe the txn-based
function just delegates its core to the plain version. But I don't think
the API really should include such modal flags.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: retry_txn (was: svn commit: rev 7096 - in trunk/subversion: libsvn_fs tests/libsvn_fs)
Posted by "C.Michael Pilato" <cm...@collab.net>.
Greg Stein <gs...@lyra.org> writes:
> [ dang. deleted the original commit mail ]
>
> On Fri, Sep 19, 2003 at 03:31:46PM -0700, Greg Stein wrote:
> > On Fri, Sep 19, 2003 at 11:45:04AM -0500, cmpilato@tigris.org wrote:
> > >...
> > > Log:
> > > Here we go. A first step towards solving issue #1499 (the oh-my-gosh-
> > > our-bdb-transaction-usage-is-horrible bug).
>
> I think this pattern is incorrect. Rather than having one function which
> operates in two *entirely* different modes based on a rather nondescript 0
> or 1 passed to it, it would have been better to have two function names.
>
> Keep _retry_txn for dbtxn-based operations. Use _retry for plain ops.
> Under the covers, you might factor it with a txn, or maybe the txn-based
> function just delegates its core to the plain version. But I don't think
> the API really should include such modal flags.
Noted.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org