[jira] [Comment Edited] (FLINK-6105) Properly handle InterruptedException in HadoopInputFormatBase

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307281#comment-16307281 ] 

Ted Yu edited comment on FLINK-6105 at 9/20/18 4:29 PM:
--------------------------------------------------------

In flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/RollingSink.java :
{code}
              try {
                Thread.sleep(500);
              } catch (InterruptedException e1) {
                // ignore it
              }
{code}
Interrupt status should be restored, or throw InterruptedIOException.


was (Author: yuzhihong@gmail.com):
In flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/RollingSink.java :
{code}
              try {
                Thread.sleep(500);
              } catch (InterruptedException e1) {
                // ignore it
              }
{code}
Interrupt status should be restored, or throw InterruptedIOException .

> Properly handle InterruptedException in HadoopInputFormatBase
> -------------------------------------------------------------
>
>                 Key: FLINK-6105
>                 URL: https://issues.apache.org/jira/browse/FLINK-6105
>             Project: Flink
>          Issue Type: Bug
>          Components: DataStream API
>            Reporter: Ted Yu
>            Assignee: zhangminglei
>            Priority: Major
>
> When catching InterruptedException, we should throw InterruptedIOException instead of IOException.
> The following example is from HadoopInputFormatBase :
> {code}
>     try {
>       splits = this.mapreduceInputFormat.getSplits(jobContext);
>     } catch (InterruptedException e) {
>       throw new IOException("Could not get Splits.", e);
>     }
> {code}
> There may be other places where IOE is thrown.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)