You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by jeroenvlek <gi...@git.apache.org> on 2015/03/05 12:34:26 UTC
[GitHub] gora pull request: NUTCH-1946: Added transitive dep to hbase-commo...
GitHub user jeroenvlek opened a pull request:
https://github.com/apache/gora/pull/21
NUTCH-1946: Added transitive dep to hbase-common-0.98.8-hadoop2.jar
The comment says it all. I used the same exclusion pattern as with hbase-client, given my unfamiliarity with the project, someone else might want to skim over that.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeroenvlek/gora master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/21.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21
----
commit ed50069203d56a2919b7d06170bdc702dfeea8d8
Author: Jeroen Vlek <jv...@datamantics.com>
Date: 2015-03-05T11:33:49Z
NUTCH-1946: Added transitive dep to hbase-common-0.98.8-hadoop2.jar
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: NUTCH-1946: Added transitive dep to hbase-commo...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/gora/pull/21#discussion_r25921656
--- Diff: gora-hbase/pom.xml ---
@@ -117,6 +117,18 @@
<dependency>
<groupId>org.apache.hbase</groupId>
+ <artifactId>hbase-common</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
--- End diff --
If we have exclude it in the main pom.xml do we need to exclude it again here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: NUTCH-1946: Added transitive dep to hbase-commo...
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/21#issuecomment-168985170
@jeroenvlek can you please close off this pull request? We are in the process of addressing [GORA-443](https://issues.apache.org/jira/browse/GORA-443). Thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: NUTCH-1946: Added transitive dep to hbase-commo...
Posted by jeroenvlek <gi...@git.apache.org>.
Github user jeroenvlek commented on a diff in the pull request:
https://github.com/apache/gora/pull/21#discussion_r25929622
--- Diff: pom.xml ---
@@ -896,6 +896,38 @@
</exclusions>
</dependency>
+ <!-- HBase Dependencies -->
+ <dependency>
+ <groupId>org.apache.hbase</groupId>
+ <artifactId>hbase-common</artifactId>
+ <version>${hbase.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>avro</artifactId>
+ </exclusion>
+ <exclusion>
--- End diff --
It was a direct copy of hbase-client, so I fixed the indentation of both.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: NUTCH-1946: Added transitive dep to hbase-commo...
Posted by jeroenvlek <gi...@git.apache.org>.
Github user jeroenvlek closed the pull request at:
https://github.com/apache/gora/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: NUTCH-1946: Added transitive dep to hbase-commo...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/gora/pull/21#discussion_r25921634
--- Diff: pom.xml ---
@@ -896,6 +896,38 @@
</exclusions>
</dependency>
+ <!-- HBase Dependencies -->
+ <dependency>
+ <groupId>org.apache.hbase</groupId>
+ <artifactId>hbase-common</artifactId>
+ <version>${hbase.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>avro</artifactId>
+ </exclusion>
+ <exclusion>
--- End diff --
Style nit: the alignment of the XML tags are not right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: NUTCH-1946: Added transitive dep to hbase-commo...
Posted by jeroenvlek <gi...@git.apache.org>.
Github user jeroenvlek commented on a diff in the pull request:
https://github.com/apache/gora/pull/21#discussion_r25929774
--- Diff: gora-hbase/pom.xml ---
@@ -117,6 +117,18 @@
<dependency>
<groupId>org.apache.hbase</groupId>
+ <artifactId>hbase-common</artifactId>
+ <scope>compile</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
--- End diff --
http://basementcoders.com/2010/05/maven-exclusions-not-always-inherited/
It depends. According to the link above, this exclusion actually causes the other exclusions in the main pom.xml to be *included* again. Is that on purpose? Do we then still need the other exclusions in the parent pom.xml?
My knowledge of Maven runs a bit short here. The difference with the example in the link above, is that in the parent pom one exclusion is stated in a dependency management section, and the child pom just states its dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora issue #21: NUTCH-1946: Added transitive dep to hbase-common-0.98.8-hado...
Posted by purplewall1206 <gi...@git.apache.org>.
Github user purplewall1206 commented on the issue:
https://github.com/apache/gora/pull/21
hbase-0.94 didn't work well on my server , nutch will throw some exceptions like
> java.lang.ClassNotFoundException: org.apache.gora.hbase.store.HBaseStore
so as the suggestion on [nutch wiki](http://wiki.apache.org/nutch/Nutch2Tutorial)
HBase 0.98.8-hadoop2 works well on my server(centOS 6)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---