You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/11 14:07:51 UTC

[GitHub] [flink] dawidwys commented on a change in pull request #17581: [FLINK-24552][tests] Moved randomization of buffer debloat from Strea…

dawidwys commented on a change in pull request #17581:
URL: https://github.com/apache/flink/pull/17581#discussion_r747528336



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/testutils/MiniClusterResource.java
##########
@@ -186,6 +190,12 @@ private void startMiniCluster() throws Exception {
         configuration.setInteger(JobManagerOptions.PORT, 0);
         configuration.setString(RestOptions.BIND_PORT, "0");
 
+        // randomize ITTests for enabling buffer de-bloating
+        if (RANDOMIZE_BUFFER_DEBLOAT_CONFIG

Review comment:
       It's a pity we need to randomize tests in two different places. Can we at least cross reference the two in a comment? We should also try to explain which place we should use for what class of options.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org