[GitHub] [skywalking-data-collect-protocol] kezhenxu94 commented on a diff in pull request #70: Add layer to event

[GitBox <gi...@apache.org>]

kezhenxu94 commented on code in PR #70:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/70#discussion_r846726070


##########
event/Event.proto:
##########
@@ -65,6 +65,9 @@ message Event {
   // The end time (in milliseconds) of the event. , measured between the current time and midnight, January 1, 1970 UTC.
   // This field may be empty if the event has not stopped yet, otherwise it should be a valid timestamp after `startTime`.
   int64 endTime = 8;
+  
+  // Name of the layer to which the event belongs. If absent, the OAP would set `layer`=`ID: 0, NAME: undefined`.

Review Comment:
   Currently, there is no layer concept in all events. We can require all new events to have a layer, for old events (reported by old tools / agents), just leave their layers to be empty as before. @wu-sheng correct me if I'm wrong, because the UI can show events of ALL layers that include events without a layer, this is safe, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org