You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/17 18:26:27 UTC
[GitHub] [superset] dd-willgan commented on a change in pull request #16627: other: Provide option to add environment variables to only supersetNode
dd-willgan commented on a change in pull request #16627:
URL: https://github.com/apache/superset/pull/16627#discussion_r711266605
##########
File path: helm/superset/templates/deployment.yaml
##########
@@ -79,6 +79,12 @@ spec:
value: {{ $value | quote }}
{{- end }}
{{- end }}
+ {{- if .Values.supersetNode.env }}
Review comment:
@dpgaspar No but after thinking about it I would prefer to keep it to match how extraEnv is read in this file and others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org