You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2015/09/29 22:17:55 UTC
[GitHub] flink pull request: [FLINK-2703] Prepare Flink for using it with L...
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1194
[FLINK-2703] Prepare Flink for using it with Logback.
i was talking to a user recently who asked for using Logback instead of Log4j.
This pull request is adding a section in the "Best practices" page which describes how to use Logback for running Flink locally from the IDE and on a cluster.
I also needed to change the pom's of `flink-dist`: They are now placing log4j and slf4j-log4j as separate jars into the lib/ folder (instead of packing them into the fat jar).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink2703
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1194.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1194
----
commit 505778994ce9bce1a8389e4c7ba0c782512cd65a
Author: Robert Metzger <rm...@apache.org>
Date: 2015-09-28T10:16:29Z
[FLINK-2703] Prepare Flink for being used with Logback.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2703] Prepare Flink for using it with L...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1194#issuecomment-144192517
Nice addition, looks good to me!
+1 to merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2703] Prepare Flink for using it with L...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1194#discussion_r40730119
--- Diff: flink-dist/src/main/assemblies/bin.xml ---
@@ -40,6 +40,9 @@ under the License.
<includes>
<include>org.apache.flink:flink-python</include>
+ <include>org.apache.flink:flink-python</include>
--- End diff --
Accidental line duplication?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2703] Prepare Flink for using it with L...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1194#discussion_r40764829
--- Diff: flink-dist/src/main/assemblies/bin.xml ---
@@ -40,6 +40,9 @@ under the License.
<includes>
<include>org.apache.flink:flink-python</include>
+ <include>org.apache.flink:flink-python</include>
--- End diff --
Oops... Yes. I'll remove that again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2703] Prepare Flink for using it with L...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1194#issuecomment-144459509
Thank you for the review. I'm merging this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2703] Prepare Flink for using it with L...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---