You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/09 07:14:55 UTC

[GitHub] [airflow] vikramkoka opened a new pull request #12937: Enhanced TaskFlow API tutorial to use @dag decorator

vikramkoka opened a new pull request #12937:
URL: https://github.com/apache/airflow/pull/12937


   Updated both the tutorial python file in the example_dags directory
   and the tutorial documentation
   
   Closes #12269 
   
   @casassg @ashb @kaxil 
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on pull request #12937: Enhanced TaskFlow API tutorial to use @dag decorator

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12937:
URL: https://github.com/apache/airflow/pull/12937#issuecomment-741655385


   Pylint failures are unrelated and already fixed in master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #12937: Enhanced TaskFlow API tutorial to use @dag decorator

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12937:
URL: https://github.com/apache/airflow/pull/12937#issuecomment-741600284


   [The Workflow run](https://github.com/apache/airflow/actions/runs/410082654) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #12937: Enhanced TaskFlow API tutorial to use @dag decorator

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12937:
URL: https://github.com/apache/airflow/pull/12937#issuecomment-741600789


   [The Workflow run](https://github.com/apache/airflow/actions/runs/410100126) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb merged pull request #12937: Enhanced TaskFlow API tutorial to use @dag decorator

Posted by GitBox <gi...@apache.org>.
ashb merged pull request #12937:
URL: https://github.com/apache/airflow/pull/12937


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on a change in pull request #12937: Enhanced TaskFlow API tutorial to use @dag decorator

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #12937:
URL: https://github.com/apache/airflow/pull/12937#discussion_r539172986



##########
File path: docs/apache-airflow/tutorial_taskflow_api.rst
##########
@@ -90,6 +92,15 @@ the Transform task for summarization, and then invoked the Load task with the su
 The dependencies between the tasks and the passing of data between these tasks which could be
 running on different workers on different nodes on the network is all handled by Airflow.
 
+Now to actually enable this to be run as a DAG, we invoke the python function

Review comment:
       Nice !




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org