You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/07/25 09:56:26 UTC
[GitHub] flink pull request #4392: [FLINK-7226] [webUI] Properly include UTF-8 in con...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4392
[FLINK-7226] [webUI] Properly include UTF-8 in content-type header
This PR corrects the `content-encoding` header introduced in FLINK-5705. As documented [here](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding) this header is used to denote how the content is compressed (for example, with gzip or deflate).
That the strings are encoded using `UTF-8` should be documented in the `content-type` header instead, using the `charset` parameter, as documented [here](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Type).
There was also a bug in `TestBaseUtils#getFromHTTP`, where the UTF-8 charset was retrieved from the `content-encoding` header.
I've added tests to make sure we don't break this _again_.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7226
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4392.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4392
----
commit 3093d53f6f07afcc351b99a39586463fb0a0b83e
Author: zentol <ch...@apache.org>
Date: 2017-07-19T11:51:35Z
[FLINK-7226] [webUI] Properly include UTF-8 in content-type header
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4392: [FLINK-7226] [webUI] Properly include UTF-8 in content-ty...
Posted by willddy <gi...@git.apache.org>.
Github user willddy commented on the issue:
https://github.com/apache/flink/pull/4392
I still found this issue only when the job id not found as follows in the latest v1.3.2. Pls. reopen the issue
localhost:8001/jobs/0e12860ffae73f23dc104aedb814d6d2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4392: [FLINK-7226] [webUI] Properly include UTF-8 in con...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4392#discussion_r129514223
--- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JobCancellationWithSavepointHandlers.java ---
@@ -266,7 +266,7 @@ public void onComplete(Throwable failure, Object resp) throws Throwable {
response.headers().set(HttpHeaders.Names.LOCATION, location);
- response.headers().set(HttpHeaders.Names.CONTENT_TYPE, "application/json");
+ response.headers().set(HttpHeaders.Names.CONTENT_TYPE, "application/json; charset=UTF-8");
--- End diff --
yes, will fix it and search for other occurrences while merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4392: [FLINK-7226] [webUI] Properly include UTF-8 in con...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4392
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4392: [FLINK-7226] [webUI] Properly include UTF-8 in con...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4392#discussion_r129317438
--- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JobCancellationWithSavepointHandlers.java ---
@@ -266,7 +266,7 @@ public void onComplete(Throwable failure, Object resp) throws Throwable {
response.headers().set(HttpHeaders.Names.LOCATION, location);
- response.headers().set(HttpHeaders.Names.CONTENT_TYPE, "application/json");
+ response.headers().set(HttpHeaders.Names.CONTENT_TYPE, "application/json; charset=UTF-8");
--- End diff --
Should this also use `ENCODING.name()`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4392: [FLINK-7226] [webUI] Properly include UTF-8 in content-ty...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4392
@willddy Please open a new JIRA @ https://issues.apache.org/jira/browse/FLINK with a description of what error you are encountering. I looked through the code and we never set the encoding header _anywhere_; i expect your issue to be separate from this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---