You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/18 17:46:36 UTC
[GitHub] [arrow] lidavidm opened a new pull request #10353: ARROW-12717: [C++][Python] Add find_substring kernel
lidavidm opened a new pull request #10353:
URL: https://github.com/apache/arrow/pull/10353
This adds a very simple lfind kernel. If the substring is not found, -1 is reported. Nulls are propagated. Regexes are not supported, nor is rfind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on pull request #10353: ARROW-12717: [C++][Python] Add find_substring kernel
Posted by GitBox <gi...@apache.org>.
ianmcook commented on pull request #10353:
URL: https://github.com/apache/arrow/pull/10353#issuecomment-845941056
@lidavidm do you intend for this to be merged before or after #10369?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #10353: ARROW-12717: [C++][Python] Add find_substring kernel
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #10353:
URL: https://github.com/apache/arrow/pull/10353#issuecomment-845937294
Rebased and fixed conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #10353: ARROW-12717: [C++][Python] Add find_substring kernel
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #10353:
URL: https://github.com/apache/arrow/pull/10353#issuecomment-844140543
A thought I had is that we could/should support binary/large_binary too. And, we may want to output int32 instead of int64 for the non-large_ arrays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #10353: ARROW-12717: [C++][Python] Add find_substring kernel
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #10353:
URL: https://github.com/apache/arrow/pull/10353#issuecomment-844159530
Updated to support binary/large_binary and to output int32 for non-large types. I'm still postponing regex find/rfind for a different issue. Though, I'm not sure if we want rfind to be an option of this kernel or its own kernel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #10353: ARROW-12717: [C++][Python] Add find_substring kernel
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #10353:
URL: https://github.com/apache/arrow/pull/10353#issuecomment-845942892
Let's merge this one first, then I'll fix up the other (though it's no big deal either way).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 closed pull request #10353: ARROW-12717: [C++][Python] Add find_substring kernel
Posted by GitBox <gi...@apache.org>.
cyb70289 closed pull request #10353:
URL: https://github.com/apache/arrow/pull/10353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10353: ARROW-12717: [C++][Python] Add find_substring kernel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10353:
URL: https://github.com/apache/arrow/pull/10353#issuecomment-843569222
https://issues.apache.org/jira/browse/ARROW-12717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org