Re: [PR] [SPARK-58866][SQL] Add expression-level entry points to optimizer rules [spark]

["uros-b (via GitHub)" <gi...@apache.org>]

uros-b commented on PR #58119:
URL: https://github.com/apache/spark/pull/58119#issuecomment-5508858887

   Just two more minor nits:
   
   - DateTimeUtils.makeTimestampX reading a clock would slip past the literal-children gate. Worth either softening the doc wording or matching the specific builder types if strict scoping was the intent.
   
   - Only the NTZ path is directly tested. The other three variants take the identical helper path (I verified each passes the gate), so coverage is logically equivalent, a one-line LTZ case would just make that a bit explicit.
   
   Otherwise looks good, thank you @matvei-zamiatin-db for addressing all previous comments!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org