[GitHub] sijie opened a new pull request #1270: Improve `BookKeeperAdmin#format` to avoid constructing redundant resources

[GitBox <gi...@apache.org>]

sijie opened a new pull request #1270: Improve `BookKeeperAdmin#format` to avoid constructing redundant resources
URL: https://github.com/apache/bookkeeper/pull/1270
 
 
   
   
   Descriptions of the changes in this PR:
   
   *Problem*
   
   After metadata service uri change, all the metadata managers can be retrieved via metadata drivers.
   So there is no need to construct another bookkeeper client to get ledger manager factory for formatting ledger metadata.
   
   *Solution*
   
   - remove constructing bookkeeper client and use the metadata driver to get ledger manager factory to format ledger metadata
   - expose layout manager in bookie driver as well
   - since we are adding `getLayoutManager` in bookie driver, we need to update `MetadataDriversTest`. cleanup the test drivers in `MetadataDriversTest`.
   
   Related Issue: #1269 
   
   > ---
   > Be sure to do all of the following to help us incorporate your contribution
   > quickly and easily:
   >
   > If this PR is a BookKeeper Proposal (BP):
   >
   > - [ ] Make sure the PR title is formatted like:
   >     `<BP-#>: Description of bookkeeper proposal`
   >     `e.g. BP-1: 64 bits ledger is support`
   > - [ ] Attach the master issue link in the description of this PR.
   > - [ ] Attach the google doc link if the BP is written in Google Doc.
   >
   > Otherwise:
   > 
   > - [ ] Make sure the PR title is formatted like:
   >     `<Issue #>: Description of pull request`
   >     `e.g. Issue 123: Description ...`
   > - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
   > - [ ] Replace `<Issue #>` in the title with the actual Issue number.
   > 
   > ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services