You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2023/05/27 02:52:38 UTC
[GitHub] [spark] beliefer opened a new pull request, #41339: [SPARK-43820][SPARK-43822][SPARK-43823][SPARK-43826][SPARK-43827] Assign names to the error class _LEGACY_ERROR_TEMP_241[1-7]
beliefer opened a new pull request, #41339:
URL: https://github.com/apache/spark/pull/41339
### What changes were proposed in this pull request?
The pr aims to assign a name to the error class _LEGACY_ERROR_TEMP_241[1-7].
### Why are the changes needed?
Improve the error framework.
### Does this PR introduce _any_ user-facing change?
'No'.
### How was this patch tested?
Exists test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #41339: [SPARK-43820][SPARK-43822][SPARK-43823][SPARK-43826][SPARK-43827] Assign names to the error class _LEGACY_ERROR_TEMP_241[1-7]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #41339:
URL: https://github.com/apache/spark/pull/41339#issuecomment-1566544932
@MaxGekk Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #41339: [SPARK-43820][SPARK-43822][SPARK-43823][SPARK-43826][SPARK-43827] Assign names to the error class _LEGACY_ERROR_TEMP_241[1-7]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #41339:
URL: https://github.com/apache/spark/pull/41339#issuecomment-1566083172
+1, LGTM. Merging to master.
Thank you, @beliefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #41339: [SPARK-43820][SPARK-43822][SPARK-43823][SPARK-43826][SPARK-43827] Assign names to the error class _LEGACY_ERROR_TEMP_241[1-7]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #41339: [SPARK-43820][SPARK-43822][SPARK-43823][SPARK-43826][SPARK-43827] Assign names to the error class _LEGACY_ERROR_TEMP_241[1-7]
URL: https://github.com/apache/spark/pull/41339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #41339: [SPARK-43820][SPARK-43822][SPARK-43823][SPARK-43826][SPARK-43827] Assign names to the error class _LEGACY_ERROR_TEMP_241[1-7]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #41339:
URL: https://github.com/apache/spark/pull/41339#discussion_r1208505374
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -378,18 +380,18 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB
case j @ Join(_, _, _, Some(condition), _) if condition.dataType != BooleanType =>
j.failAnalysis(
- errorClass = "_LEGACY_ERROR_TEMP_2416",
+ errorClass = "JOIN_CONDITION_IS_NOT_BOOLEAN_TYPE",
messageParameters = Map(
- "join" -> condition.sql,
- "type" -> condition.dataType.catalogString))
+ "joinCondition" -> toSQLExpr(condition),
+ "conditionType" -> toSQLType(condition.dataType)))
case j @ AsOfJoin(_, _, _, Some(condition), _, _, _)
if condition.dataType != BooleanType =>
- j.failAnalysis(
- errorClass = "_LEGACY_ERROR_TEMP_2417",
- messageParameters = Map(
- "condition" -> condition.sql,
- "dataType" -> condition.dataType.catalogString))
+ throw SparkException.internalError(
+ msg = s"join condition '${toSQLExpr(condition)}' " +
+ s"of type ${toSQLType(condition.dataType)} is not a boolean.",
+ context = j.origin.getQueryContext,
+ summary = j.origin.context.summary)
Review Comment:
This one is converted to the internal error because `resolveSelfJoinCondition` returns only boolean conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #41339: [SPARK-43820][SPARK-43822][SPARK-43823][SPARK-43826][SPARK-43827] Assign names to the error class _LEGACY_ERROR_TEMP_241[1-7]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #41339:
URL: https://github.com/apache/spark/pull/41339#discussion_r1208001705
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1393,6 +1403,11 @@
}
}
},
+ "JOIN_CONDITION_IS_NOT_BOOLEAN_TYPE" : {
+ "message" : [
+ "join condition '<joinCondition>' of type <conditionType> is not a boolean."
Review Comment:
```suggestion
"The join condition <joinCondition> has the invalid type <conditionType>, expected \"BOOLEAN\"."
```
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -617,6 +617,11 @@
"Not found an encoder of the type <typeName> to Spark SQL internal representation. Consider to change the input type to one of supported at '<docroot>/sql-ref-datatypes.html'."
]
},
+ "EVENT_TIME_IS_NOT_ON_TIMESTAMP_TYPE" : {
+ "message" : [
+ "Event time must be defined on a window or a timestamp, but <eventName> is of type <eventType>."
Review Comment:
```suggestion
"The event time <eventName> has the invalid type <eventType>, but expected \"TIMESTAMP\"."
```
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1371,6 +1376,11 @@
],
"sqlState" : "42903"
},
+ "INVALID_WINDOW_SPEC_FOR_AGGREGATION_FUNC" : {
+ "message" : [
+ "Cannot specify order by or frame for '<aggFunc>'."
Review Comment:
```suggestion
"Cannot specify ORDER BY or a window frame for <aggFunc>."
```
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1780,6 +1795,11 @@
],
"sqlState" : "22023"
},
+ "SEED_EXPRESSION_IS_UNRESOLVED" : {
Review Comment:
```suggestion
"NON_FOLDABLE_SEED_EXPRESSION" : {
```
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1780,6 +1795,11 @@
],
"sqlState" : "22023"
},
+ "SEED_EXPRESSION_IS_UNRESOLVED" : {
+ "message" : [
+ "Input argument to <argName> must be a constant."
Review Comment:
```suggestion
"The seed expression <seedExpr> of the expression <exprWithSeed> must be foldable."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org