You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "David Byttow (JIRA)" <ji...@apache.org> on 2008/07/29 01:46:31 UTC
[jira] Created: (SHINDIG-478) First pass of client-side OpenSocial
Templates feature
First pass of client-side OpenSocial Templates feature
------------------------------------------------------
Key: SHINDIG-478
URL: https://issues.apache.org/jira/browse/SHINDIG-478
Project: Shindig
Issue Type: New Feature
Components: Features (Javascript)
Reporter: David Byttow
Attachments: templates.patch
This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
To run this feature in your local Shindig server browse to:
http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
Other links:
Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-478) First pass of client-side OpenSocial
Templates feature
Posted by "David Byttow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Byttow updated SHINDIG-478:
---------------------------------
Attachment: opensocial-templates.patch
Patch for this issue.
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: opensocial-templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-478) First pass of client-side
OpenSocial Templates feature
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617947#action_12617947 ]
Chris Chabot commented on SHINDIG-478:
--------------------------------------
Sorry i should've seen that David, i got lost in the large patch file.
+ <script src="http://google-jstemplate.googlecode.com/svn/trunk/util.js"></script>
+ <script src="http://google-jstemplate.googlecode.com/svn/trunk/jsevalcontext.js"></script>
+ <script src="http://google-jstemplate.googlecode.com/svn/trunk/jstemplate.js"></script>
Yea seems fine to me for now, though i think the svn externals trick is probably the best long term solution, especially since that allows you to lock in to specific revisions etc. (what if the trunk destabilizes during a development cycle?). Not every one has maven or caja, but svn is available for anyone using shindig.
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-478) First pass of client-side
OpenSocial Templates feature
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617925#action_12617925 ]
Chris Chabot commented on SHINDIG-478:
--------------------------------------
One comment rang an alarm bell with me:
"Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib."
Shindig contains both Java & PHP implementations, and the PHP version (& users) don't really 'do maven'. So it would have my preference that any feature related problems were not solved by using that :)
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-478) First pass of client-side
OpenSocial Templates feature
Posted by "David Byttow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617941#action_12617941 ]
David Byttow commented on SHINDIG-478:
--------------------------------------
That's precisely what I'm doing, which is the open issue. No more alarm bells? :)
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-478) First pass of client-side
OpenSocial Templates feature
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627052#action_12627052 ]
Kevin Brown commented on SHINDIG-478:
-------------------------------------
No, we won't apply the patch without unit tests. That's standard policy here.
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: opensocial-templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SHINDIG-478) First pass of
client-side OpenSocial Templates feature
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617944#action_12617944 ]
chabotc edited comment on SHINDIG-478 at 7/29/08 1:31 PM:
---------------------------------------------------------------
ps another possible solution would be to count on SVN externals trickery to pull in the externally (svn) hosted files.
See: http://svnbook.red-bean.com/en/1.0/ch07s03.html
was (Author: chabotc):
ps another possible solution would be to count on SVN externals trickery to pull in the externally (svn) hosted files.
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-478) First pass of client-side
OpenSocial Templates feature
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617944#action_12617944 ]
Chris Chabot commented on SHINDIG-478:
--------------------------------------
ps another possible solution would be to count on SVN externals trickery to pull in the externally (svn) hosted files.
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-478) First pass of client-side OpenSocial
Templates feature
Posted by "David Byttow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Byttow updated SHINDIG-478:
---------------------------------
Attachment: opensocial-templates.patch
I have re-attached the patch file with tests. Because there is no framework currently set up, I am including a README with instructions on how to run the test, which involved making sure that you have a local copy of jsunit installed.
Integration of a testing framework into the build system for JS unit tests is going to be a necessity in order to break this extra step and dependency on downloading jsunit.
There are currently 49 individual (passing) unit tests for the entire library and adding them has bloated the patch file somewhat significantly.
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: opensocial-templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-478) First pass of client-side
OpenSocial Templates feature
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617940#action_12617940 ]
Chris Chabot commented on SHINDIG-478:
--------------------------------------
Yea counting on caja would only create more of a problem :)
I guess the quick-and-dirty solution would be to do the same thing as we do with analyitics, use external references? like:
<feature>
<name>analytics</name>
<dependency>core</dependency>
<gadget>
<script src="http://www.google.com/ig/lib/liburchin.js"/>
<script src="http://www.google.com/ig/lib/libanalytics.js"/>
</gadget>
</feature>
Dirty, but ... hey it's good for the browser cache right? :)
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-478) First pass of client-side
OpenSocial Templates feature
Posted by "David Byttow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617928#action_12617928 ]
David Byttow commented on SHINDIG-478:
--------------------------------------
More generally the open issue really is - how to handle retrieving jstemplate at build time (Caja does this?). For now, it works to just retrieve via http, but ultimately not a final solution.
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-478) First pass of client-side
OpenSocial Templates feature
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617932#action_12617932 ]
Cassie Doll commented on SHINDIG-478:
-------------------------------------
Caja is java only atm.
Chris - how could we include the other project by reference?
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-478) First pass of client-side
OpenSocial Templates feature
Posted by "David Byttow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627043#action_12627043 ]
David Byttow commented on SHINDIG-478:
--------------------------------------
Hi Louis,
Thanks for your comments. The unit tests and sample gadget will soon follow once this patch is committed.
The rest of your comments have been addressed.
Thanks.
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: opensocial-templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-478) First pass of client-side
OpenSocial Templates feature
Posted by "David Byttow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627142#action_12627142 ]
David Byttow commented on SHINDIG-478:
--------------------------------------
I have re-attached the patch file with tests. Because there is no framework currently set up, I am including a README with instructions on how to run the test, which involved making sure that you have a local copy of jsunit installed.
Integration of a testing framework into the build system for JS unit tests is going to be a necessity in order to break this extra step and dependency on downloading jsunit.
There are currently 49 individual (passing) unit tests for the entire library and adding them has bloated the patch file somewhat significantly.
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: opensocial-templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-478) First pass of client-side OpenSocial
Templates feature
Posted by "David Byttow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Byttow updated SHINDIG-478:
---------------------------------
Attachment: (was: opensocial-templates.patch)
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: opensocial-templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-478) First pass of client-side OpenSocial
Templates feature
Posted by "David Byttow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Byttow updated SHINDIG-478:
---------------------------------
Comment: was deleted
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: opensocial-templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-478) First pass of client-side OpenSocial
Templates feature
Posted by "David Byttow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Byttow updated SHINDIG-478:
---------------------------------
Component/s: (was: Features (Javascript))
OpenSocial feature (Javascript)
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-478) First pass of client-side OpenSocial
Templates feature
Posted by "David Byttow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Byttow updated SHINDIG-478:
---------------------------------
Attachment: opensocial-templates.patch
Comments addressed
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: opensocial-templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-478) First pass of client-side OpenSocial
Templates feature
Posted by "David Byttow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Byttow updated SHINDIG-478:
---------------------------------
Attachment: templates.patch
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: Features (Javascript)
> Reporter: David Byttow
> Attachments: templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-478) First pass of client-side OpenSocial
Templates feature
Posted by "David Byttow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Byttow updated SHINDIG-478:
---------------------------------
Attachment: (was: templates.patch)
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-478) First pass of client-side OpenSocial
Templates feature
Posted by "David Byttow (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Byttow updated SHINDIG-478:
---------------------------------
Attachment: (was: opensocial-templates.patch)
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: opensocial-templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-478) First pass of client-side OpenSocial
Templates feature
Posted by "Louis Ryan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Louis Ryan resolved SHINDIG-478.
--------------------------------
Resolution: Fixed
Assignee: Louis Ryan
I have checked this initial version in. Im going to open some JIRA issues for work I think needs to be done to make the tests more consumeable and improve the packaging structure.
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Assignee: Louis Ryan
> Attachments: opensocial-templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-478) First pass of client-side
OpenSocial Templates feature
Posted by "Louis Ryan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625784#action_12625784 ]
Louis Ryan commented on SHINDIG-478:
------------------------------------
David,
I took a quick look through and the code looks very clean so Im happy to apply this patch mostly as is.
A couple of notes...
- there are no unit tests and no sample test gadget. Are you guys at the point where a gadget rendered in the samplecontainer using this feature could do something useful? We have an EndToEnd test that uses HTML unit which may sufficiently simulate a browser environment for you to use, certainly worth a look.
- feature.xml - I would definitely put a comment that serving JS files from googlecode is for testing only and should never be used in a production setting. Im assuming it convenient to do this at the moment but the files will need to be checked into Shindig svn when you have a stable version or containers should host them independently.
- no files in Shindig have authorship comments, I personally think its OK for TODOs to have people linked to them but we haven't been doing that either.
base.js
42: Should use same pattern of var opensocial = opensocial || {} instead of window.opensocial. I see a couple of different variations of gadgets, window.gadgets & window["gadgets"]. Was there some compiler you guys were trying to make happy?
82: onlyWhitespace: /^[ \n]*$/ - This is only matching space and newline, no tabs?
> First pass of client-side OpenSocial Templates feature
> ------------------------------------------------------
>
> Key: SHINDIG-478
> URL: https://issues.apache.org/jira/browse/SHINDIG-478
> Project: Shindig
> Issue Type: New Feature
> Components: OpenSocial feature (Javascript)
> Reporter: David Byttow
> Attachments: opensocial-templates.patch
>
>
> This is a drop of the code that was prototyped and developed alongside of the proposal for OpenSocial Templates (http://groups.google.com/group/opensocial-and-gadgets-spec/web/overview)
> Open issue: Currently the feature links to three files in code.google.com. Instead, should use maven to grab these files and build the lib.
> To run this feature in your local Shindig server browse to:
> http://your_server/gadgets/ifr?url=http://ostemplates-demo.appspot.com/staging/hello.xml
> A full demo of this code can be found at: http://ostemplates-demo.appspot.com/
> Other links:
> Spec discussions for OpenSocial templates, data pipelining, and standard tags: http://groups.yahoo.com/group/os-templates
> Wiki being used by the above group: http://wiki.opensocial-templates.org/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.