You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/05/29 08:21:04 UTC
[GitHub] [james-project] chibenwa opened a new pull request #466: JAMES-3261 Migrate all docker images to JIB
chibenwa opened a new pull request #466:
URL: https://github.com/apache/james-project/pull/466
This follows https://github.com/apache/james-project/pull/399 that provided JIB image for memory guice.
This PR provides the same thing for all other Guice distributions as well as updates the documentation accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #466: JAMES-3261 Migrate all docker images to JIB
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #466:
URL: https://github.com/apache/james-project/pull/466#discussion_r642402472
##########
File path: server/container/guice/cassandra-guice/pom.xml
##########
@@ -273,6 +278,124 @@
<build>
<plugins>
+ <plugin>
+ <groupId>com.googlecode.maven-download-plugin</groupId>
+ <artifactId>download-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>install-jbpm</id>
+ <goals>
+ <goal>wget</goal>
+ </goals>
+ <phase>package</phase>
+ <configuration>
+ <url>https://github.com/glowroot/glowroot/releases/download/v0.13.4/glowroot-0.13.4-dist.zip</url>
+ <unpack>true</unpack>
+ <outputDirectory>${project.build.directory}</outputDirectory>
+ <md5>93d472281a67ab8404033a88280c23c9</md5>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>copy-glowroot-resources</id>
+ <goals>
+ <goal>copy-resources</goal>
+ </goals>
+ <phase>package</phase>
+ <configuration>
+ <outputDirectory>${basedir}/target/glowroot</outputDirectory>
+ <resources>
+ <resource>
+ <directory>src/main/glowroot</directory>
+ <filtering>true</filtering>
+ </resource>
+ </resources>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>com.google.cloud.tools</groupId>
+ <artifactId>jib-maven-plugin</artifactId>
+ <configuration>
+ <from>
+ <image>adoptopenjdk:11-jdk-hotspot</image>
Review comment:
I am unsure we should change the running images. What are the pros and cons?
Maybe we need more discussion and you could propose that change (and related fixes like JVM option passing, glowroot). Likely not a drop in replacement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #466: JAMES-3261 Migrate all docker images to JIB
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #466:
URL: https://github.com/apache/james-project/pull/466#issuecomment-855173292
Just rebased prior a merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #466: JAMES-3261 Migrate all docker images to JIB
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #466:
URL: https://github.com/apache/james-project/pull/466#issuecomment-851405030
> It's a bit sad to see all the duplicated glowroot json files :/
Was the case before ;-)
If you want to have a shot at factorising it ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on a change in pull request #466: JAMES-3261 Migrate all docker images to JIB
Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #466:
URL: https://github.com/apache/james-project/pull/466#discussion_r642550207
##########
File path: server/container/guice/cassandra-guice/pom.xml
##########
@@ -273,6 +278,124 @@
<build>
<plugins>
+ <plugin>
+ <groupId>com.googlecode.maven-download-plugin</groupId>
+ <artifactId>download-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>install-jbpm</id>
+ <goals>
+ <goal>wget</goal>
+ </goals>
+ <phase>package</phase>
+ <configuration>
+ <url>https://github.com/glowroot/glowroot/releases/download/v0.13.4/glowroot-0.13.4-dist.zip</url>
+ <unpack>true</unpack>
+ <outputDirectory>${project.build.directory}</outputDirectory>
+ <md5>93d472281a67ab8404033a88280c23c9</md5>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>copy-glowroot-resources</id>
+ <goals>
+ <goal>copy-resources</goal>
+ </goals>
+ <phase>package</phase>
+ <configuration>
+ <outputDirectory>${basedir}/target/glowroot</outputDirectory>
+ <resources>
+ <resource>
+ <directory>src/main/glowroot</directory>
+ <filtering>true</filtering>
+ </resource>
+ </resources>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>com.google.cloud.tools</groupId>
+ <artifactId>jib-maven-plugin</artifactId>
+ <configuration>
+ <from>
+ <image>adoptopenjdk:11-jdk-hotspot</image>
Review comment:
pros:
- less attack surface in the running container as there is way less stuff installed that can be used to exploit
- much much lighter images (some report 75% reduction)
cons:
- forget docker exec distroless containers only contain strictly necessary (hence ephemeral containers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #466: JAMES-3261 Migrate all docker images to JIB
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #466:
URL: https://github.com/apache/james-project/pull/466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #466: JAMES-3261 Migrate all docker images to JIB
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #466:
URL: https://github.com/apache/james-project/pull/466#discussion_r642402472
##########
File path: server/container/guice/cassandra-guice/pom.xml
##########
@@ -273,6 +278,124 @@
<build>
<plugins>
+ <plugin>
+ <groupId>com.googlecode.maven-download-plugin</groupId>
+ <artifactId>download-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>install-jbpm</id>
+ <goals>
+ <goal>wget</goal>
+ </goals>
+ <phase>package</phase>
+ <configuration>
+ <url>https://github.com/glowroot/glowroot/releases/download/v0.13.4/glowroot-0.13.4-dist.zip</url>
+ <unpack>true</unpack>
+ <outputDirectory>${project.build.directory}</outputDirectory>
+ <md5>93d472281a67ab8404033a88280c23c9</md5>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>copy-glowroot-resources</id>
+ <goals>
+ <goal>copy-resources</goal>
+ </goals>
+ <phase>package</phase>
+ <configuration>
+ <outputDirectory>${basedir}/target/glowroot</outputDirectory>
+ <resources>
+ <resource>
+ <directory>src/main/glowroot</directory>
+ <filtering>true</filtering>
+ </resource>
+ </resources>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>com.google.cloud.tools</groupId>
+ <artifactId>jib-maven-plugin</artifactId>
+ <configuration>
+ <from>
+ <image>adoptopenjdk:11-jdk-hotspot</image>
Review comment:
I am unsure we should change the running images. What are the pros and cons?
Maybe we need more discussion and you could propose that change (and related fixes like JVM option passing, glowroot, CLI). Likely not a drop in replacement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on a change in pull request #466: JAMES-3261 Migrate all docker images to JIB
Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #466:
URL: https://github.com/apache/james-project/pull/466#discussion_r642550207
##########
File path: server/container/guice/cassandra-guice/pom.xml
##########
@@ -273,6 +278,124 @@
<build>
<plugins>
+ <plugin>
+ <groupId>com.googlecode.maven-download-plugin</groupId>
+ <artifactId>download-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>install-jbpm</id>
+ <goals>
+ <goal>wget</goal>
+ </goals>
+ <phase>package</phase>
+ <configuration>
+ <url>https://github.com/glowroot/glowroot/releases/download/v0.13.4/glowroot-0.13.4-dist.zip</url>
+ <unpack>true</unpack>
+ <outputDirectory>${project.build.directory}</outputDirectory>
+ <md5>93d472281a67ab8404033a88280c23c9</md5>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>copy-glowroot-resources</id>
+ <goals>
+ <goal>copy-resources</goal>
+ </goals>
+ <phase>package</phase>
+ <configuration>
+ <outputDirectory>${basedir}/target/glowroot</outputDirectory>
+ <resources>
+ <resource>
+ <directory>src/main/glowroot</directory>
+ <filtering>true</filtering>
+ </resource>
+ </resources>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>com.google.cloud.tools</groupId>
+ <artifactId>jib-maven-plugin</artifactId>
+ <configuration>
+ <from>
+ <image>adoptopenjdk:11-jdk-hotspot</image>
Review comment:
pros:
- less attack surface in the running container as there is way less stuff installed that can be used to exploit
- much much lighter images (some report 75% reduction)
cons:
- forget docker exec distroless containers only contain strictly necessary (hence ephemeral containers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on a change in pull request #466: JAMES-3261 Migrate all docker images to JIB
Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #466:
URL: https://github.com/apache/james-project/pull/466#discussion_r642384313
##########
File path: server/container/guice/cassandra-guice/pom.xml
##########
@@ -273,6 +278,124 @@
<build>
<plugins>
+ <plugin>
+ <groupId>com.googlecode.maven-download-plugin</groupId>
+ <artifactId>download-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>install-jbpm</id>
+ <goals>
+ <goal>wget</goal>
+ </goals>
+ <phase>package</phase>
+ <configuration>
+ <url>https://github.com/glowroot/glowroot/releases/download/v0.13.4/glowroot-0.13.4-dist.zip</url>
+ <unpack>true</unpack>
+ <outputDirectory>${project.build.directory}</outputDirectory>
+ <md5>93d472281a67ab8404033a88280c23c9</md5>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>copy-glowroot-resources</id>
+ <goals>
+ <goal>copy-resources</goal>
+ </goals>
+ <phase>package</phase>
+ <configuration>
+ <outputDirectory>${basedir}/target/glowroot</outputDirectory>
+ <resources>
+ <resource>
+ <directory>src/main/glowroot</directory>
+ <filtering>true</filtering>
+ </resource>
+ </resources>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>com.google.cloud.tools</groupId>
+ <artifactId>jib-maven-plugin</artifactId>
+ <configuration>
+ <from>
+ <image>adoptopenjdk:11-jdk-hotspot</image>
Review comment:
```suggestion
<image>gcr.io/distroless/java:11</image>
```
along with https://martinheinz.dev/blog/49 for debugging ?
applies to all pom.xml which use jib :D
##########
File path: server/container/guice/jpa-smtp/src/main/extensions-jars/README.md
##########
@@ -2,4 +2,4 @@
The jar in this folder will be added to JAMES classpath when mounted under /root/extensions-jars inside the running container.
-You can use it to add your customs Mailets/Matchers.
+You can use it to add you customs Mailets/Matchers.
Review comment:
```suggestion
You can use it to add your custom Mailets/Matchers.
```
##########
File path: server/container/guice/cassandra-guice/pom.xml
##########
@@ -273,6 +278,124 @@
<build>
<plugins>
+ <plugin>
+ <groupId>com.googlecode.maven-download-plugin</groupId>
+ <artifactId>download-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>install-jbpm</id>
Review comment:
```suggestion
<id>install-glowroot</id>
```
for all pom.xml in this PR :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org