You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jonashaag (via GitHub)" <gi...@apache.org> on 2025/10/06 20:34:06 UTC

[PR] Allow more settings without vendor prefix [arrow-rs-object-store]

jonashaag opened a new pull request, #500:
URL: https://github.com/apache/arrow-rs-object-store/pull/500

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
   
   Similar to https://github.com/apache/arrow-rs-object-store/pull/467, also allow `server_side_encryption` instead of `aws_server_side_encryption` and some other `aws_` prefixed settings.
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please call them out.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Allow more settings without vendor prefix [arrow-rs-object-store]

Posted by "kylebarron (via GitHub)" <gi...@apache.org>.
kylebarron commented on PR #500:
URL: https://github.com/apache/arrow-rs-object-store/pull/500#issuecomment-3438945636

   I don't think there are existing tests for the string config parsing, but maybe I missed them.
   
   I'm not sure what kind of test would make sense here, because this feels like a situation where the test just copies 1:1 the implementation of the enum creation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Allow more settings without vendor prefix [arrow-rs-object-store]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #500:
URL: https://github.com/apache/arrow-rs-object-store/pull/500#issuecomment-3453345254

   Thanks again @jonashaag and @kylebarron 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Allow more settings without vendor prefix [arrow-rs-object-store]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #500:
URL: https://github.com/apache/arrow-rs-object-store/pull/500


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Allow more settings without vendor prefix [arrow-rs-object-store]

Posted by "kylebarron (via GitHub)" <gi...@apache.org>.
kylebarron commented on PR #500:
URL: https://github.com/apache/arrow-rs-object-store/pull/500#issuecomment-3451786783

   CI should pass after #519 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Allow more settings without vendor prefix [arrow-rs-object-store]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #500:
URL: https://github.com/apache/arrow-rs-object-store/pull/500#issuecomment-3438922074

   I restarted the failed MSRV check (some sort of network error)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Allow more settings without vendor prefix [arrow-rs-object-store]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #500:
URL: https://github.com/apache/arrow-rs-object-store/pull/500#issuecomment-3439061899

   Yeah, so sounds good to merge it. Thanks
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org